From: Sonny Rao <sonnyrao@us.ibm.com>
To: ron.mercer@qlogic.com,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Milton Miller <miltonm@bga.com>,
Linux Driver <Linux-Driver@qlogic.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"sonnyrao@linux.vnet.ibm.com" <sonnyrao@linux.vnet.ibm.com>
Subject: Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
Date: Thu, 18 Nov 2010 17:12:12 -0600 [thread overview]
Message-ID: <20101118231212.GU32203@us.ibm.com> (raw)
In-Reply-To: <20101118221713.GB14333@linux-ox1b.qlogic.org>
On Thu, Nov 18, 2010 at 02:17:14PM -0800, Ron Mercer wrote:
> On Thu, Nov 18, 2010 at 01:50:02PM -0800, Sonny Rao wrote:
> > Driver appears to be mistaking the permission field with default value
> > in the case of debug and qlge_irq_type.
> >
> > Driver is also passing debug as a bitmask into netif_msg_init()
> > which wants a number of bits. Ron Mercer suggests we should
> > change this to pass in -1 so the defaults get used instead,
> > which makes the default much less verbose.
> >
> > Signed-off-by: Milton Miller <miltonm@bga.com>
> > Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
>
> Milton/Sonny,
> Did you happen to test this to see if the log output was the same?
Well, I haven't tried the -1 but I suspect it is much more sane than
the 15 I had before because that was excessively verbose and I always
ended up turning it down. I'll try it out and see.
--
Sonny Rao, LTC OzLabs, BML team
WARNING: multiple messages have this Message-ID (diff)
From: Sonny Rao <sonnyrao@us.ibm.com>
To: ron.mercer@qlogic.com,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Milton Miller <miltonm@bga.com>,
Linux Driver <Linux-Driver@qlogic.com>,
"linux-kernel@vger.kernel.org" <lin
Subject: Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
Date: Thu, 18 Nov 2010 17:12:12 -0600 [thread overview]
Message-ID: <20101118231212.GU32203@us.ibm.com> (raw)
In-Reply-To: <20101118221713.GB14333@linux-ox1b.qlogic.org>
On Thu, Nov 18, 2010 at 02:17:14PM -0800, Ron Mercer wrote:
> On Thu, Nov 18, 2010 at 01:50:02PM -0800, Sonny Rao wrote:
> > Driver appears to be mistaking the permission field with default value
> > in the case of debug and qlge_irq_type.
> >
> > Driver is also passing debug as a bitmask into netif_msg_init()
> > which wants a number of bits. Ron Mercer suggests we should
> > change this to pass in -1 so the defaults get used instead,
> > which makes the default much less verbose.
> >
> > Signed-off-by: Milton Miller <miltonm@bga.com>
> > Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
>
> Milton/Sonny,
> Did you happen to test this to see if the log output was the same?
Well, I haven't tried the -1 but I suspect it is much more sane than
the 15 I had before because that was excessively verbose and I always
ended up turning it down. I'll try it out and see.
--
Sonny Rao, LTC OzLabs, BML team
next prev parent reply other threads:[~2010-11-18 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 21:50 [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level Sonny Rao
2010-11-18 22:17 ` Ron Mercer
2010-11-18 23:12 ` Sonny Rao [this message]
2010-11-18 23:12 ` Sonny Rao
-- strict thread matches above, loose matches on Subject: below --
2010-11-18 10:25 Sonny Rao
2010-11-18 17:22 ` Ron Mercer
2010-11-18 19:30 ` David Miller
2010-11-22 16:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118231212.GU32203@us.ibm.com \
--to=sonnyrao@us.ibm.com \
--cc=Linux-Driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
--cc=sonnyrao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.