From: Dave Chinner <david@fromorbit.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@lst.de>, "Theodore Ts'o" <tytso@mit.edu>,
Chris Mason <chris.mason@oracle.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/13] IO-less dirty throttling
Date: Fri, 19 Nov 2010 13:28:24 +1100 [thread overview]
Message-ID: <20101119022824.GB13830@dastard> (raw)
In-Reply-To: <20101117175900.0d7878e5.akpm@linux-foundation.org>
On Wed, Nov 17, 2010 at 05:59:00PM -0800, Andrew Morton wrote:
> On Thu, 18 Nov 2010 12:40:51 +1100 Dave Chinner <david@fromorbit.com> wrote:
> > Yeah, sorry, should have posted them - I didn't because I snapped
> > the numbers before the run had finished. Without series:
> >
> > 373.19user 14940.49system 41:42.17elapsed 612%CPU (0avgtext+0avgdata 82560maxresident)k
> > 0inputs+0outputs (403major+2599763minor)pagefaults 0swaps
> >
> > With your series:
> >
> > 359.64user 5559.32system 40:53.23elapsed 241%CPU (0avgtext+0avgdata 82496maxresident)k
> > 0inputs+0outputs (312major+2598798minor)pagefaults 0swaps
> >
> > So the wall time with your series is lower, and system CPU time is
> > way down (as I've already noted) for this workload on XFS.
>
> How much of that benefit is an accounting artifact, moving work away
> from the calling process's CPU and into kernel threads?
As I spelled out in my original results, the sustained CPU usage for
the unmodified kernel is ~780% - 620% fs_mark, 80% bdi-flusher, 80%
kswapd (i.e. completely CPU bound on the 8p test VM). With this
series, the sustained CPU usage is about 380% - 250% fs_mark, 80%
bdi-flusher, 50% kswapd.
IOWs, this series _halved_ the total sustained CPU usage even after
taking into account all the kernel threads. With wall time also
being reduced and the number of IOs issued dropping by 25%, I find
it hard to classify the result as anything other than spectacular...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
Chris Mason <chris.mason@oracle.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mel Gorman <mel@csn.ul.ie>, Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/13] IO-less dirty throttling
Date: Fri, 19 Nov 2010 13:28:24 +1100 [thread overview]
Message-ID: <20101119022824.GB13830@dastard> (raw)
In-Reply-To: <20101117175900.0d7878e5.akpm@linux-foundation.org>
On Wed, Nov 17, 2010 at 05:59:00PM -0800, Andrew Morton wrote:
> On Thu, 18 Nov 2010 12:40:51 +1100 Dave Chinner <david@fromorbit.com> wrote:
> > Yeah, sorry, should have posted them - I didn't because I snapped
> > the numbers before the run had finished. Without series:
> >
> > 373.19user 14940.49system 41:42.17elapsed 612%CPU (0avgtext+0avgdata 82560maxresident)k
> > 0inputs+0outputs (403major+2599763minor)pagefaults 0swaps
> >
> > With your series:
> >
> > 359.64user 5559.32system 40:53.23elapsed 241%CPU (0avgtext+0avgdata 82496maxresident)k
> > 0inputs+0outputs (312major+2598798minor)pagefaults 0swaps
> >
> > So the wall time with your series is lower, and system CPU time is
> > way down (as I've already noted) for this workload on XFS.
>
> How much of that benefit is an accounting artifact, moving work away
> from the calling process's CPU and into kernel threads?
As I spelled out in my original results, the sustained CPU usage for
the unmodified kernel is ~780% - 620% fs_mark, 80% bdi-flusher, 80%
kswapd (i.e. completely CPU bound on the 8p test VM). With this
series, the sustained CPU usage is about 380% - 250% fs_mark, 80%
bdi-flusher, 50% kswapd.
IOWs, this series _halved_ the total sustained CPU usage even after
taking into account all the kernel threads. With wall time also
being reduced and the number of IOs issued dropping by 25%, I find
it hard to classify the result as anything other than spectacular...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-19 2:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 3:58 [PATCH 00/13] IO-less dirty throttling Wu Fengguang
2010-11-17 3:58 ` Wu Fengguang
2010-11-17 3:58 ` Wu Fengguang
2010-11-17 7:25 ` Dave Chinner
2010-11-17 7:25 ` Dave Chinner
2010-11-17 7:25 ` Dave Chinner
2010-11-17 10:06 ` Wu Fengguang
2010-11-17 10:06 ` Wu Fengguang
2010-11-17 10:06 ` Wu Fengguang
2010-11-18 1:40 ` Dave Chinner
2010-11-18 1:40 ` Dave Chinner
2010-11-18 1:59 ` Andrew Morton
2010-11-18 1:59 ` Andrew Morton
2010-11-18 2:50 ` Wu Fengguang
2010-11-18 2:50 ` Wu Fengguang
2010-11-18 3:19 ` Wu Fengguang
2010-11-18 3:19 ` Wu Fengguang
2010-11-19 2:28 ` Dave Chinner [this message]
2010-11-19 2:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101119022824.GB13830@dastard \
--to=david@fromorbit.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.