From: David Miller <davem@davemloft.net>
To: grant.likely@secretlab.ca
Cc: ddaney@caviumnetworks.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
cyril@ti.com, arnaud.patard@rtp-net.org,
benh@kernel.crashing.org
Subject: Re: [PATCH v2] of/phylib: Use device tree properties to initialize Marvell PHYs.
Date: Mon, 22 Nov 2010 08:35:16 -0800 (PST) [thread overview]
Message-ID: <20101122.083516.112578583.davem@davemloft.net> (raw)
In-Reply-To: <20101120042848.GB7005@angua.secretlab.ca>
From: Grant Likely <grant.likely@secretlab.ca>
Date: Fri, 19 Nov 2010 21:28:49 -0700
> On Fri, Nov 19, 2010 at 02:13:18PM -0800, David Daney wrote:
>> Some aspects of PHY initialization are board dependent, things like
>> indicator LED connections and some clocking modes cannot be determined
>> by probing. The dev_flags element of struct phy_device can be used to
>> control these things if an appropriate value can be passed from the
>> Ethernet driver. We run into problems however if the PHY connections
>> are specified by the device tree. There is no way for the Ethernet
>> driver to know what flags it should pass.
>>
>> If we are using the device tree, the struct phy_device will be
>> populated with the device tree node corresponding to the PHY, and we
>> can extract extra configuration information from there.
>>
>> The next question is what should the format of that information be?
>> It is highly device specific, and the device tree representation
>> should not be tied to any arbitrary kernel defined constants. A
>> straight forward representation is just to specify the exact bits that
>> should be set using the "marvell,reg-init" property:
>>
>> phy5: ethernet-phy@5 {
>> reg = <5>;
>> compatible = "marvell,88e1149r";
>> marvell,reg-init =
>> /* led[0]:1000, led[1]:100, led[2]:10, led[3]:tx */
>> <3 0x10 0 0x5777>, /* Reg 3,16 <- 0x5777 */
>> /* mix %:0, led[0123]:drive low off hiZ */
>> <3 0x11 0 0x00aa>, /* Reg 3,17 <- 0x00aa */
>> /* default blink periods. */
>> <3 0x12 0 0x4105>, /* Reg 3,18 <- 0x4105 */
>> /* led[4]:rx, led[5]:dplx, led[45]:drive low off hiZ */
>> <3 0x13 0 0x0a60>; /* Reg 3,19 <- 0x0a60 */
>> };
>>
>> phy6: ethernet-phy@6 {
>> reg = <6>;
>> compatible = "marvell,88e1118";
>> marvell,reg-init =
>> /* Fix rx and tx clock transition timing */
>> <2 0x15 0xffcf 0>, /* Reg 2,21 Clear bits 4, 5 */
>> /* Adjust LED drive. */
>> <3 0x11 0 0x442a>, /* Reg 3,17 <- 0442a */
>> /* irq, blink-activity, blink-link */
>> <3 0x10 0 0x0242>; /* Reg 3,16 <- 0x0242 */
>> };
>>
>> The Marvell PHYs have a page select register at register 22 (0x16), we
>> can specify any register by its page and register number. These are
>> the first and second word. The third word contains a mask to be ANDed
>> with the existing register value, and the fourth word is ORed with the
>> result to yield the new register value. The new marvell_of_reg_init
>> function leaves the page select register unchanged, so a call to it
>> can be dropped into the .config_init functions without unduly
>> affecting the state of the PHY.
>>
>> If CONFIG_OF_MDIO is not set, there is no of_node, or no
>> "marvell,reg-init" property, the PHY initialization is unchanged.
>>
>> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Cyril Chemparathy <cyril@ti.com>
>> Cc: David Daney <ddaney@caviumnetworks.com>
>> Cc: Arnaud Patard <arnaud.patard@rtp-net.org>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Untested/compiled, but looks good to me.
>
> Reviewed-by: Grant Likely <grant.likely@secretlab.ca>
Also applied, thanks everyone.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cyril-l0cyMroinI0@public.gmane.org,
arnaud.patard-dQbF7i+pzddAfugRpC6u6w@public.gmane.org
Subject: Re: [PATCH v2] of/phylib: Use device tree properties to initialize Marvell PHYs.
Date: Mon, 22 Nov 2010 08:35:16 -0800 (PST) [thread overview]
Message-ID: <20101122.083516.112578583.davem@davemloft.net> (raw)
In-Reply-To: <20101120042848.GB7005-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Date: Fri, 19 Nov 2010 21:28:49 -0700
> On Fri, Nov 19, 2010 at 02:13:18PM -0800, David Daney wrote:
>> Some aspects of PHY initialization are board dependent, things like
>> indicator LED connections and some clocking modes cannot be determined
>> by probing. The dev_flags element of struct phy_device can be used to
>> control these things if an appropriate value can be passed from the
>> Ethernet driver. We run into problems however if the PHY connections
>> are specified by the device tree. There is no way for the Ethernet
>> driver to know what flags it should pass.
>>
>> If we are using the device tree, the struct phy_device will be
>> populated with the device tree node corresponding to the PHY, and we
>> can extract extra configuration information from there.
>>
>> The next question is what should the format of that information be?
>> It is highly device specific, and the device tree representation
>> should not be tied to any arbitrary kernel defined constants. A
>> straight forward representation is just to specify the exact bits that
>> should be set using the "marvell,reg-init" property:
>>
>> phy5: ethernet-phy@5 {
>> reg = <5>;
>> compatible = "marvell,88e1149r";
>> marvell,reg-init =
>> /* led[0]:1000, led[1]:100, led[2]:10, led[3]:tx */
>> <3 0x10 0 0x5777>, /* Reg 3,16 <- 0x5777 */
>> /* mix %:0, led[0123]:drive low off hiZ */
>> <3 0x11 0 0x00aa>, /* Reg 3,17 <- 0x00aa */
>> /* default blink periods. */
>> <3 0x12 0 0x4105>, /* Reg 3,18 <- 0x4105 */
>> /* led[4]:rx, led[5]:dplx, led[45]:drive low off hiZ */
>> <3 0x13 0 0x0a60>; /* Reg 3,19 <- 0x0a60 */
>> };
>>
>> phy6: ethernet-phy@6 {
>> reg = <6>;
>> compatible = "marvell,88e1118";
>> marvell,reg-init =
>> /* Fix rx and tx clock transition timing */
>> <2 0x15 0xffcf 0>, /* Reg 2,21 Clear bits 4, 5 */
>> /* Adjust LED drive. */
>> <3 0x11 0 0x442a>, /* Reg 3,17 <- 0442a */
>> /* irq, blink-activity, blink-link */
>> <3 0x10 0 0x0242>; /* Reg 3,16 <- 0x0242 */
>> };
>>
>> The Marvell PHYs have a page select register at register 22 (0x16), we
>> can specify any register by its page and register number. These are
>> the first and second word. The third word contains a mask to be ANDed
>> with the existing register value, and the fourth word is ORed with the
>> result to yield the new register value. The new marvell_of_reg_init
>> function leaves the page select register unchanged, so a call to it
>> can be dropped into the .config_init functions without unduly
>> affecting the state of the PHY.
>>
>> If CONFIG_OF_MDIO is not set, there is no of_node, or no
>> "marvell,reg-init" property, the PHY initialization is unchanged.
>>
>> Signed-off-by: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
>> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> Cc: Cyril Chemparathy <cyril-l0cyMroinI0@public.gmane.org>
>> Cc: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
>> Cc: Arnaud Patard <arnaud.patard-dQbF7i+pzddAfugRpC6u6w@public.gmane.org>
>> Cc: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
>
> Untested/compiled, but looks good to me.
>
> Reviewed-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Also applied, thanks everyone.
next prev parent reply other threads:[~2010-11-22 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 22:13 [PATCH v2] of/phylib: Use device tree properties to initialize Marvell PHYs David Daney
2010-11-19 22:13 ` David Daney
2010-11-19 23:02 ` Andy Fleming
2010-11-19 23:38 ` David Daney
2010-11-19 23:38 ` David Daney
2010-11-20 4:15 ` Grant Likely
2010-11-20 4:15 ` Grant Likely
2010-11-20 4:28 ` Grant Likely
2010-11-20 4:28 ` Grant Likely
2010-11-22 16:35 ` David Miller [this message]
2010-11-22 16:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122.083516.112578583.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnaud.patard@rtp-net.org \
--cc=benh@kernel.crashing.org \
--cc=cyril@ti.com \
--cc=ddaney@caviumnetworks.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.