From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Berg, Johannes" <johannes.berg@intel.com>,
Arnd Hannemann <arnd@arndnet.de>, Michal Hocko <mhocko@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Richard Purdie <rpurdie@linux.intel.com>
Subject: Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS
Date: Tue, 23 Nov 2010 10:17:56 +0100 [thread overview]
Message-ID: <20101123091756.GA22530@elte.hu> (raw)
In-Reply-To: <20101123000232.e51b99b7.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 23 Nov 2010 08:57:42 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > * Berg, Johannes <johannes.berg@intel.com> wrote:
> >
> > > > > Hmm. For some reason I thought this patch had made it into -mm,
> > > > > but I never double-checked and then went travelling ...
> > > > >
> > > > > http://lkml.org/lkml/2010/10/26/79
> > > >
> > > > oops, I filed it in the wrong drawer, under "non-urgent". It then got
> > > > buried in new paperwork. But not lost!
> > > >
> > > > Gee it's big. Could you please double-check that it is still complete?
> > >
> > > Will do. I suspect it should, unless you took new LED drivers? But then
> > > again you will now probably want a patch against -rc, not -mm?
> >
> > It applied with a fuzz here so something changed in that file since you made the
> > patch. I did a quick review of drivers/leds/Kconfig and your patch seems complete to
> > me.
>
> It looks complete to me as well. It already fixes LEDS_NETXBIG.
It fails to build on x86 64-bit allmodconfig:
drivers/leds/led-triggers.c:39:20: error: ‘TRIG_NAME_MAX’ undeclared (first use in this function)
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:56:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:57:33: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:58:24: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:60:22: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:80:21: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:82:15: error: ‘struct led_classdev’ has no member named ‘trigger’
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:87:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:88:15: error: ‘struct led_classdev’ has no member named ‘trigger’
drivers/leds/led-triggers.c:88:44: error: ‘struct led_classdev’ has no member named ‘trigger’
drivers/leds/led-triggers.c:89:12: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:90:41: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:92:39: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:94:19: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:103:6: error: expected identifier or ‘(’ before ‘do’
drivers/leds/led-triggers.c:103:6: error: expected identifier or ‘(’ before ‘while’
drivers/leds/led-triggers.c:127:19: error: ‘led_trigger_set’ undeclared here (not in a function)
drivers/leds/led-triggers.c:129:6: error: expected identifier or ‘(’ before ‘do’
drivers/leds/led-triggers.c:129:6: error: expected identifier or ‘(’ before ‘while’
drivers/leds/led-triggers.c:135:19: error: ‘led_trigger_remove’ undeclared here (not in a function)
drivers/leds/led-triggers.c:137:6: error: expected identifier or ‘(’ before ‘do’
drivers/leds/led-triggers.c:137:6: error: expected identifier or ‘(’ before ‘while’
drivers/leds/led-triggers.c:153:19: error: ‘led_trigger_set_default’ undeclared here (not in a function)
drivers/leds/led-triggers.c:162:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:163:25: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:167:2: error: request for member ‘next_trig’ in something not a structure or union
drivers/leds/led-triggers.c:168:19: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:168:34: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:174:24: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:180:23: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:181:16: error: ‘struct led_classdev’ has no member named ‘trigger’
drivers/leds/led-triggers.c:182:50: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:184:21: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:198:19: error: dereferencing pointer to incomplete type
drivers/leds/led-triggers.c:204:23: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:205:15: error: ‘struct led_classdev’ has no member named ‘trigger’
drivers/leds/led-triggers.c:207:21: error: ‘struct led_classdev’ has no member named ‘trigger_lock’
drivers/leds/led-triggers.c:215:6: error: expected identifier or ‘(’ before ‘do’
drivers/leds/led-triggers.c:215:6: error: expected identifier or ‘(’ before ‘while’
drivers/leds/led-triggers.c:232:19: error: ‘led_trigger_event’ undeclared here (not in a function)
drivers/leds/led-triggers.c:234:6: error: expected identifier or ‘(’ before ‘do’
drivers/leds/led-triggers.c:234:6: error: expected identifier or ‘(’ before ‘while’
drivers/leds/led-triggers.c:253:19: error: ‘led_trigger_register_simple’ undeclared here (not in a function)
drivers/leds/led-triggers.c:255:6: error: expected identifier or ‘(’ before ‘do’
drivers/leds/led-triggers.c:255:6: error: expected identifier or ‘(’ before ‘while’
drivers/leds/led-triggers.c:261:19: error: ‘led_trigger_unregister_simple’ undeclared here (not in a function)
net/rfkill/core.c:67:21: error: field ‘led_trigger’ has incomplete type
net/rfkill/core.c:147:11: error: ‘struct led_classdev’ has no member named ‘trigger’
net/rfkill/core.c:171:2: error: implicit declaration of function ‘led_trigger_register’
net/rfkill/core.c:176:2: error: implicit declaration of function ‘led_trigger_unregister’
net/mac80211/led.c:59:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct led_trigger’
net/mac80211/led.c:63:16: error: dereferencing pointer to incomplete type
net/mac80211/led.c:64:3: error: implicit declaration of function ‘led_trigger_register’
net/mac80211/led.c:70:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct led_trigger’
net/mac80211/led.c:74:16: error: dereferencing pointer to incomplete type
net/mac80211/led.c:81:36: error: invalid application of ‘sizeof’ to incomplete type ‘struct led_trigger’
net/mac80211/led.c:85:19: error: dereferencing pointer to incomplete type
net/mac80211/led.c:92:36: error: invalid application of ‘sizeof’ to incomplete type ‘struct led_trigger’
net/mac80211/led.c:96:19: error: dereferencing pointer to incomplete type
net/mac80211/led.c:107:3: error: implicit declaration of function ‘led_trigger_unregister’
net/netfilter/xt_LED.c:47:21: error: field ‘netfilter_led_trigger’ has incomplete type
net/netfilter/xt_LED.c:132:2: error: implicit declaration of function ‘led_trigger_register’
net/netfilter/xt_LED.c:183:2: error: implicit declaration of function ‘led_trigger_unregister’
Thanks,
Ingo
next prev parent reply other threads:[~2010-11-23 9:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 14:20 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS Michal Hocko
2010-11-16 17:41 ` Berg, Johannes
2010-11-18 8:24 ` Michal Hocko
2010-11-18 16:52 ` Berg, Johannes
2010-11-22 16:58 ` Arnd Hannemann
2010-11-23 6:32 ` Ingo Molnar
2010-11-23 7:32 ` Berg, Johannes
2010-11-23 7:36 ` Andrew Morton
2010-11-23 7:41 ` Berg, Johannes
2010-11-23 7:44 ` Andrew Morton
2010-11-23 7:57 ` Berg, Johannes
2010-11-23 8:02 ` Ingo Molnar
2010-11-23 7:57 ` Ingo Molnar
2010-11-23 8:02 ` Andrew Morton
2010-11-23 8:09 ` Berg, Johannes
2010-11-23 9:17 ` Ingo Molnar [this message]
2010-11-23 9:35 ` Berg, Johannes
2010-11-23 9:59 ` Ingo Molnar
2010-11-23 9:41 ` Johannes Berg
2010-11-29 23:03 ` Andrew Morton
2010-11-30 0:22 ` Randy Dunlap
2010-11-30 11:25 ` Ingo Molnar
2010-11-23 7:44 ` Ingo Molnar
2010-11-23 7:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123091756.GA22530@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndnet.de \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.