From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Arnd Hannemann <arnd@arndnet.de>, Michal Hocko <mhocko@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Richard Purdie <rpurdie@linux.intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS
Date: Tue, 30 Nov 2010 12:25:25 +0100 [thread overview]
Message-ID: <20101130112525.GA9639@elte.hu> (raw)
In-Reply-To: <20101129150323.a03a09bf.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 23 Nov 2010 10:41:30 +0100
> Johannes Berg <johannes@sipsolutions.net> wrote:
>
> > On Tue, 2010-11-23 at 09:17 +0000, Ingo Molnar wrote:
> >
> > > It fails to build on x86 64-bit allmodconfig:
> >
> > Let's not modify them to tristate then, too many ifdefs.
> >
> > johannes
> >
> >
> > Subject: leds: fix up dependencies
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > It's not useful to build LED triggers when
> > there's no LEDs that can be triggered by
> > them. Therefore, fix up the dependencies
> > so that this cannot happen, and fix a few
> > users that select triggers to depend on
> > LEDS_CLASS as well (there is also one user
> > that also selects LEDS_CLASS, which is OK).
>
> Ingo, Randy: does this work for you?
Yes, it does, havent seen a leds build failure for some time.
Tested-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2010-11-30 11:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 14:20 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS Michal Hocko
2010-11-16 17:41 ` Berg, Johannes
2010-11-18 8:24 ` Michal Hocko
2010-11-18 16:52 ` Berg, Johannes
2010-11-22 16:58 ` Arnd Hannemann
2010-11-23 6:32 ` Ingo Molnar
2010-11-23 7:32 ` Berg, Johannes
2010-11-23 7:36 ` Andrew Morton
2010-11-23 7:41 ` Berg, Johannes
2010-11-23 7:44 ` Andrew Morton
2010-11-23 7:57 ` Berg, Johannes
2010-11-23 8:02 ` Ingo Molnar
2010-11-23 7:57 ` Ingo Molnar
2010-11-23 8:02 ` Andrew Morton
2010-11-23 8:09 ` Berg, Johannes
2010-11-23 9:17 ` Ingo Molnar
2010-11-23 9:35 ` Berg, Johannes
2010-11-23 9:59 ` Ingo Molnar
2010-11-23 9:41 ` Johannes Berg
2010-11-29 23:03 ` Andrew Morton
2010-11-30 0:22 ` Randy Dunlap
2010-11-30 11:25 ` Ingo Molnar [this message]
2010-11-23 7:44 ` Ingo Molnar
2010-11-23 7:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130112525.GA9639@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndnet.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=randy.dunlap@oracle.com \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.