From: Dave Chinner <david@fromorbit.com>
To: Nick Piggin <npiggin@kernel.dk>
Cc: xfs@oss.sgi.com
Subject: Re: XFS reclaim lock order bug
Date: Wed, 24 Nov 2010 08:12:58 +1100 [thread overview]
Message-ID: <20101123211258.GY22876@dastard> (raw)
In-Reply-To: <20101123121802.GA4785@amd>
On Tue, Nov 23, 2010 at 11:18:02PM +1100, Nick Piggin wrote:
> Hi,
>
> IIRC I've reported this before. Perhaps it is a false positive, but even
> so it is still annoying that it triggers and turns off lockdep for
> subsequent debugging.
>
> Any chance it can get fixed or properly annotated?
It is supposed to be handled by the re-initialisation of the
ip->i_iolock in ->evict_inode (xfs_fs_evict_inode). An inode found
in the reclaim state must have passed through this reinitialisation,
so from a lockdep perspective the iolock in the vfs path is a
different context to the iolock in the reclaim path. That fixed all
the non-reclaim state related lockdep false positives, so Perhaps
there is an issue with the lockdep reclaim state checking that does
not interact well with re-initialised lock contexts?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-11-23 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 12:18 XFS reclaim lock order bug Nick Piggin
2010-11-23 21:12 ` Dave Chinner [this message]
2010-11-24 0:58 ` Nick Piggin
2010-11-24 2:26 ` Dave Chinner
2010-11-24 20:03 ` Christoph Hellwig
2010-11-25 3:48 ` Nick Piggin
2010-11-25 6:25 ` Peter Zijlstra
2010-11-25 7:08 ` Nick Piggin
2010-11-25 7:28 ` Peter Zijlstra
2010-11-25 10:32 ` Dave Chinner
2010-11-25 10:29 ` Dave Chinner
2010-11-25 10:36 ` Peter Zijlstra
2010-11-25 11:25 ` Christoph Hellwig
2010-11-25 11:37 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123211258.GY22876@dastard \
--to=david@fromorbit.com \
--cc=npiggin@kernel.dk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.