From: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: David Lamparter <equinox-cEeocvCgqOOsTnJN9+BGXg@public.gmane.org>
Cc: "dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH v2] spi/spi: don't release the spi device twice
Date: Wed, 24 Nov 2010 15:59:22 +0800 [thread overview]
Message-ID: <20101124155922.76930387@feng-i7> (raw)
In-Reply-To: <20101123164520.GA1384937-sd4rSCkhOesKVZNVnti56SRbHCANfdcW@public.gmane.org>
On Wed, 24 Nov 2010 00:45:20 +0800
David Lamparter <equinox-cEeocvCgqOOsTnJN9+BGXg@public.gmane.org> wrote:
> > This was fixed by David Lamparter in v2.6.36-rc5 3486008
> > ("spi: free children in spi_unregister_master, not siblings") and
> > broken again in v2.6.37-rc1~2^2~4 during the merge of 2b9603a0
> > ("spi: enable spi_board_info to be registered after spi_master").
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
> > ---
> > - dummy = device_for_each_child(master->dev.parent,
> > &master->dev,
> > - __unregister);
> > + dummy = device_for_each_child(&master->dev, NULL,
> > __unregister);
>
> Signed-off-by: David Lamparter <equinox-cEeocvCgqOOsTnJN9+BGXg@public.gmane.org>
>
> very simple merge/rebase/forward-port breakage...
> Feng, can you check 2b9603a0 for whether anything else got broken?
>
I just checked, all other parts should be ok.
Thanks,
Feng
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
next prev parent reply other threads:[~2010-11-24 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 13:35 [PATCH] spi/spi: don't release the spi device twice Sebastian Andrzej Siewior
[not found] ` <20101122133503.GA25553-Hfxr4Dq0UpYb1SvskN2V4Q@public.gmane.org>
2010-11-23 0:43 ` David Lamparter
[not found] ` <20101123004301.GA1034746-sd4rSCkhOesKVZNVnti56SRbHCANfdcW@public.gmane.org>
2010-11-23 10:33 ` Sebastian Andrzej Siewior
[not found] ` <4CEB985F.90805-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2010-11-23 14:24 ` Feng Tang
2010-11-23 14:59 ` [PATCH v2] " Sebastian Andrzej Siewior
[not found] ` <20101123145910.GA23880-Hfxr4Dq0UpYb1SvskN2V4Q@public.gmane.org>
2010-11-23 16:45 ` David Lamparter
[not found] ` <20101123164520.GA1384937-sd4rSCkhOesKVZNVnti56SRbHCANfdcW@public.gmane.org>
2010-11-24 7:59 ` Feng Tang [this message]
2010-12-09 16:06 ` [v2] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124155922.76930387@feng-i7 \
--to=feng.tang-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=equinox-cEeocvCgqOOsTnJN9+BGXg@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.