Re: spi/spi: don't release the spi device twice

[Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>]

David Lamparter wrote:
> This code is the old code, before patch 3486008 which you're citing.
> 3486008 does:
> 
> -       dummy = device_for_each_child(master->dev.parent, &master->dev,
> -                                       __unregister);
> +       dummy = device_for_each_child(&master->dev, NULL, __unregister);
> 
> Considering that this patch is in 2.6.36 (and 36.1), you seem to have
> mixed up your sources. Please make sure your checkout is current and
> unbroken...
Hmmm.
# git describe --long
v2.6.37-rc3-0-g3561d43

After looking at spi_unregister_master() in drivers/spi/spi.c, I see:

      dummy = device_for_each_child(master->dev.parent, &master->dev,
                      __unregister);
      device_unregister(&master->dev);
  }

This change got back in by:

commit 2b9603a0d7e395fb844af90fba71448bc8019077
Author: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date:   Mon Aug 2 15:52:15 2010 +0800

     spi: enable spi_board_info to be registered after spi_master

which is v2.6.37-rc1~2^2~4. So I probably mixed up you with Feng.

This thread starts at
http://www.mail-archive.com/spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org/msg05437.html

>David

Sebastian

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev