From: Dan Carpenter <error27@gmail.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] virt: kvm: coding style cleanups
Date: Thu, 25 Nov 2010 04:00:32 +0000 [thread overview]
Message-ID: <20101125040032.GR1522@bicker> (raw)
In-Reply-To: <1290644937.6078.9.camel@javier-laptop>
On Thu, Nov 25, 2010 at 01:28:57AM +0100, Javier Martinez Canillas wrote:
> adev->guest_msix_entries > - kzalloc(sizeof(struct msix_entry) * entry_nr->entry_nr,
> + kzalloc(sizeof(struct msix_entry) *entry_nr->entry_nr,
The original code was right and the new code is wrong.
> GFP_KERNEL);
> if (!adev->guest_msix_entries) {
> kfree(adev->host_msix_entries);
> @@ -750,7 +750,7 @@ long kvm_vm_ioctl_assigned_device(struct kvm *kvm, unsigned ioctl,
> goto out_free_irq_routing;
> r = kvm_set_irq_routing(kvm, entries, routing.nr,
> routing.flags);
> - out_free_irq_routing:
> +out_free_irq_routing:
This is a pointless change.
> vfree(entries);
> break;
You're wasting people's time here and we like newbies but it makes
everyone annoyed.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] virt: kvm: coding style cleanups
Date: Thu, 25 Nov 2010 07:00:32 +0300 [thread overview]
Message-ID: <20101125040032.GR1522@bicker> (raw)
In-Reply-To: <1290644937.6078.9.camel@javier-laptop>
On Thu, Nov 25, 2010 at 01:28:57AM +0100, Javier Martinez Canillas wrote:
> adev->guest_msix_entries =
> - kzalloc(sizeof(struct msix_entry) * entry_nr->entry_nr,
> + kzalloc(sizeof(struct msix_entry) *entry_nr->entry_nr,
The original code was right and the new code is wrong.
> GFP_KERNEL);
> if (!adev->guest_msix_entries) {
> kfree(adev->host_msix_entries);
> @@ -750,7 +750,7 @@ long kvm_vm_ioctl_assigned_device(struct kvm *kvm, unsigned ioctl,
> goto out_free_irq_routing;
> r = kvm_set_irq_routing(kvm, entries, routing.nr,
> routing.flags);
> - out_free_irq_routing:
> +out_free_irq_routing:
This is a pointless change.
> vfree(entries);
> break;
You're wasting people's time here and we like newbies but it makes
everyone annoyed.
regards,
dan carpenter
next prev parent reply other threads:[~2010-11-25 4:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 0:28 [PATCH] virt: kvm: coding style cleanups Javier Martinez Canillas
2010-11-25 0:28 ` Javier Martinez Canillas
2010-11-25 4:00 ` Dan Carpenter [this message]
2010-11-25 4:00 ` Dan Carpenter
2010-11-25 9:34 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125040032.GR1522@bicker \
--to=error27@gmail.com \
--cc=avi@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.