All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] xenalyze: Use types which have consistent sizes across 32- and 64-bit compiles
Date: Thu, 25 Nov 2010 12:17:58 +0100	[thread overview]
Message-ID: <20101125111758.GA13724@aepfle.de> (raw)
In-Reply-To: <9b3c5bb22b50106a254d.1290426236@gdunlap-desktop>

On Mon, Nov 22, George Dunlap wrote:

> Always use [unsigned] long long for 64-bit, [unsigned] int for 32-bit.

George,

there are two unsigned long left in hvm_mmio_assist_process().
I think the sizeof(unsigned long) should be sizeof(unsigned int).

Olaf

  reply	other threads:[~2010-11-25 11:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 11:43 [PATCH] xenalyze: Use types which have consistent sizes across 32- and 64-bit compiles George Dunlap
2010-11-25 11:17 ` Olaf Hering [this message]
2010-11-25 11:22   ` Tim Deegan
2010-11-25 12:09     ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101125111758.GA13724@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=george.dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.