From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, Christoph Hellwig <hch@lst.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
qemu-devel@nongnu.org
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk
Date: Fri, 26 Nov 2010 14:29:59 +0100 [thread overview]
Message-ID: <20101126132959.GA9040@lst.de> (raw)
In-Reply-To: <4CEF9407.80706@redhat.com>
On Fri, Nov 26, 2010 at 12:03:35PM +0100, Kevin Wolf wrote:
> I don't think the synchronous flushes even do what they're supposed to
> do. Shouldn't ioreq->postsync do the flush after the request has
> completed instead of doing it as soon as it has been submitted?
Indeed, that's yet another bug in the implementation.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, Christoph Hellwig <hch@lst.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
qemu-devel@nongnu.org
Subject: Re: Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk
Date: Fri, 26 Nov 2010 14:29:59 +0100 [thread overview]
Message-ID: <20101126132959.GA9040@lst.de> (raw)
In-Reply-To: <4CEF9407.80706@redhat.com>
On Fri, Nov 26, 2010 at 12:03:35PM +0100, Kevin Wolf wrote:
> I don't think the synchronous flushes even do what they're supposed to
> do. Shouldn't ioreq->postsync do the flush after the request has
> completed instead of doing it as soon as it has been submitted?
Indeed, that's yet another bug in the implementation.
next prev parent reply other threads:[~2010-11-26 13:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 13:08 [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk Stefano Stabellini
2010-11-24 13:08 ` Stefano Stabellini
2010-11-24 14:23 ` [Qemu-devel] " Gerd Hoffmann
2010-11-24 16:29 ` Kevin Wolf
2010-11-24 16:46 ` Stefano Stabellini
2010-12-14 18:43 ` [Xen-devel] " Ian Jackson
2010-12-14 18:43 ` Ian Jackson
2010-11-24 16:58 ` Christoph Hellwig
2010-11-24 18:18 ` [Xen-devel] " Jeremy Fitzhardinge
2010-11-24 18:18 ` Jeremy Fitzhardinge
2010-11-24 18:44 ` [Xen-devel] " Christoph Hellwig
2010-11-24 18:44 ` Christoph Hellwig
2010-11-24 19:55 ` [Xen-devel] " Stefano Stabellini
2010-11-24 19:55 ` Stefano Stabellini
2010-11-26 11:03 ` [Xen-devel] " Kevin Wolf
2010-11-26 11:03 ` Kevin Wolf
2010-11-26 13:29 ` Christoph Hellwig [this message]
2010-11-26 13:29 ` Christoph Hellwig
2010-11-26 15:25 ` [Xen-devel] " Stefano Stabellini
2010-11-26 15:25 ` Stefano Stabellini
[not found] ` <m2n.s.1PLKM9-000VR4@chiark.greenend.org.uk>
2010-11-25 19:30 ` [Xen-devel] " Ian Jackson
2010-11-25 19:30 ` Ian Jackson
2010-11-25 19:46 ` [Xen-devel] " Jeremy Fitzhardinge
2010-11-25 19:46 ` Jeremy Fitzhardinge
2010-11-25 23:30 ` [Xen-devel] " Christoph Hellwig
2010-11-25 23:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126132959.GA9040@lst.de \
--to=hch@lst.de \
--cc=jeremy@goop.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.