* [U-Boot] [PATCH] command_t: punt unused type
@ 2010-10-20 7:35 Mike Frysinger
2010-11-28 21:01 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-10-20 7:35 UTC (permalink / raw)
To: u-boot
The recent command clean up to constify the argv option to command funcs
missed the command_t type itself. This is probably because there are no
build time warnings from it because no one is actually using this thing.
So just punt it rather than fix it.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
include/command.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/include/command.h b/include/command.h
index 5c14616..a153ce9 100644
--- a/include/command.h
+++ b/include/command.h
@@ -86,8 +86,6 @@ extern int cmd_auto_complete(const char *const prompt, char *buf, int *np, int *
* void function (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]);
*/
-typedef void command_t (cmd_tbl_t *, int, int, char *[]);
-
#if defined(CONFIG_CMD_MEMORY) \
|| defined(CONFIG_CMD_I2C) \
|| defined(CONFIG_CMD_ITEST) \
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] command_t: punt unused type
2010-10-20 7:35 [U-Boot] [PATCH] command_t: punt unused type Mike Frysinger
@ 2010-11-28 21:01 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2010-11-28 21:01 UTC (permalink / raw)
To: u-boot
Dear Mike Frysinger,
In message <1287560109-31612-1-git-send-email-vapier@gentoo.org> you wrote:
> The recent command clean up to constify the argv option to command funcs
> missed the command_t type itself. This is probably because there are no
> build time warnings from it because no one is actually using this thing.
> So just punt it rather than fix it.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> include/command.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
Applied to "next" branch, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Die Freiheit des Menschen liegt nicht darin, dass er tun kann, was er
will, sondern darin, dass er nicht tun muss, was er nicht will.
-- Jean-Jacques Rousseau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-28 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-20 7:35 [U-Boot] [PATCH] command_t: punt unused type Mike Frysinger
2010-11-28 21:01 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.