From: Paul Mundt <lethal@linux-sh.org>
To: Simon Horman <horms@verge.net.au>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Yusuke Goda <yusuke.goda.sx@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 1/3] sh, mmc: Make mmcif_update_progress static inline
Date: Mon, 29 Nov 2010 12:55:06 +0900 [thread overview]
Message-ID: <20101129035505.GA709@linux-sh.org> (raw)
In-Reply-To: <20101127001155.GA30946@verge.net.au> <1290812579-20410-2-git-send-email-horms@verge.net.au> <1290812579-20410-1-git-send-email-horms@verge.net.au>
On Sat, Nov 27, 2010 at 08:02:57AM +0900, Simon Horman wrote:
> extern inline doesn't make much sense
>
> Cc: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
On Sat, Nov 27, 2010 at 08:02:58AM +0900, Simon Horman wrote:
> This resolves a regression that I introduced in
> "mmc, sh: Move constants to sh_mmcif.h". Having
> examined the manual and tested the code on an AP4EVB board
> it seems that the correct sequence is.
>
> 1) Write 1 to bit 31 and zeros to all other bits
> 2) Write zero to all bits
>
> Cc: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
On Sat, Nov 27, 2010 at 09:11:55AM +0900, Simon Horman wrote:
> The 16-19th bits of CE_CLK_CTRL set the
> MMC clock frequency.
>
> Cc: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Simon Horman <horms@verge.net.au>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
Yusuke Goda <yusuke.goda.sx@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 1/3] sh, mmc: Make mmcif_update_progress static inline
Date: Mon, 29 Nov 2010 03:55:06 +0000 [thread overview]
Message-ID: <20101129035505.GA709@linux-sh.org> (raw)
In-Reply-To: <20101127001155.GA30946@verge.net.au> <1290812579-20410-2-git-send-email-horms@verge.net.au> <1290812579-20410-1-git-send-email-horms@verge.net.au>
On Sat, Nov 27, 2010 at 08:02:57AM +0900, Simon Horman wrote:
> extern inline doesn't make much sense
>
> Cc: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
On Sat, Nov 27, 2010 at 08:02:58AM +0900, Simon Horman wrote:
> This resolves a regression that I introduced in
> "mmc, sh: Move constants to sh_mmcif.h". Having
> examined the manual and tested the code on an AP4EVB board
> it seems that the correct sequence is.
>
> 1) Write 1 to bit 31 and zeros to all other bits
> 2) Write zero to all bits
>
> Cc: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
On Sat, Nov 27, 2010 at 09:11:55AM +0900, Simon Horman wrote:
> The 16-19th bits of CE_CLK_CTRL set the
> MMC clock frequency.
>
> Cc: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
Applied, thanks.
next prev parent reply other threads:[~2010-11-29 3:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 23:02 [PATCH 1/3] sh, mmc: Make mmcif_update_progress static inline Simon Horman
2010-11-26 23:02 ` Simon Horman
2010-11-26 23:02 ` [PATCH 2/3] mmc, sh: Correct value for reset Simon Horman
2010-11-26 23:02 ` Simon Horman
2010-11-26 23:02 ` [PATCH 3/3] sh, mmc: Use defines when setting CE_CLK_CTRL Simon Horman
2010-11-26 23:02 ` Simon Horman
2010-11-27 0:01 ` Simon Horman
2010-11-27 0:01 ` Simon Horman
2010-11-27 0:11 ` [PATCH 3/3 v2] " Simon Horman
2010-11-27 0:11 ` Simon Horman
2010-11-27 11:54 ` Michał Mirosław
2010-11-27 11:54 ` Michał Mirosław
2010-11-27 21:17 ` Simon Horman
2010-11-27 21:17 ` Simon Horman
2010-11-29 3:55 ` Paul Mundt [this message]
2010-11-29 3:55 ` [PATCH 1/3] sh, mmc: Make mmcif_update_progress static inline Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129035505.GA709@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=cjb@laptop.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yusuke.goda.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.