All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Eric Anholt <eric@anholt.net>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: piglit regression on sandybridge
Date: Mon, 29 Nov 2010 16:52:32 +0800	[thread overview]
Message-ID: <20101129085232.GA4900@zhen-devel.sh.intel.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1034 bytes --]


Eric,

Looks the culprit for recent piglit regression on sandybridge
that caused hang is bisected to

commit 9effc1adf1e7ba57fb3b10909762b76c1ae12f61
Author: Eric Anholt <eric@anholt.net>
Date:   Mon Oct 11 16:02:08 2010 -0700

i965: re-enable gen6 IF statements in the fragment shader.

IF statements were getting flattened while they were broken.  With
Zhenyu's last fix for ENDIF's type, everything appears to have lined
up to actually work.

This regresses two tests:
glsl1-! (not) operator (1, fail)
glsl1-! (not) operator (1, pass)

but fixes tests that couldn't work before because the IFs couldn't
be flattened:
glsl-fs-discard-01
occlusion-query-discard

(and, naturally, this should be a performance improvement for apps
 that actually use IF statements to avoid executing a bunch of code).

What may go wrong with this? QA is stalled on this to continue on
running piglit..

thanks.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2010-11-29  8:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29  8:52 Zhenyu Wang [this message]
2010-11-29 19:02 ` piglit regression on sandybridge Ian Romanick
2010-11-30  1:50   ` Zhenyu Wang
2010-11-30  2:38     ` Jin, Gordon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129085232.GA4900@zhen-devel.sh.intel.com \
    --to=zhenyuw@linux.intel.com \
    --cc=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.