All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pma@sysgo.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k_htc more cleanups
Date: Mon, 29 Nov 2010 12:34:53 +0100	[thread overview]
Message-ID: <20101129113453.GA29737@pma.sysgo.com> (raw)
In-Reply-To: <20101129095915.GB28833@pma.sysgo.com>

This fixes whitespace and fixes strings.

Signed-off-by: Pavel Machek <pma@sysgo.com>

diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index c41ab8c..ac4aed7 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -16,7 +16,7 @@
 
 #include "htc.h"
 
-static int htc_issue_send(struct htc_target *target, struct sk_buff* skb,
+static int htc_issue_send(struct htc_target *target, struct sk_buff *skb,
 			  u16 len, u8 flags, u8 epid,
 			  struct ath9k_htc_tx_ctl *tx_ctl)
 {
@@ -239,7 +239,7 @@ int htc_connect_service(struct htc_target *target,
 	/* Find an available endpoint */
 	endpoint = get_next_avail_ep(target->endpoint);
 	if (!endpoint) {
-		dev_err(target->dev, "Endpoint is not available for"
+		dev_err(target->dev, "Endpoint is not available for "
 			"service %d\n", service_connreq->service_id);
 		return -EINVAL;
 	}
@@ -253,7 +253,7 @@ int htc_connect_service(struct htc_target *target,
 	skb = alloc_skb(sizeof(struct htc_conn_svc_msg) +
 			    sizeof(struct htc_frame_hdr), GFP_ATOMIC);
 	if (!skb) {
-		dev_err(target->dev, "Failed to allocate buf to send"
+		dev_err(target->dev, "Failed to allocate buf to send "
 			"service connect req\n");
 		return -ENOMEM;
 	}
@@ -274,6 +274,7 @@ int htc_connect_service(struct htc_target *target,
 
 	time_left = wait_for_completion_timeout(&target->cmd_wait, HZ);
 	if (!time_left) {
+		/* who frees skb */
 		dev_err(target->dev, "Service connection timeout for: %d\n",
 			service_connreq->service_id);
 		return -ETIMEDOUT;
@@ -434,7 +435,7 @@ struct htc_target *ath9k_htc_hw_alloc(void *hif_handle,
 
 	target = kzalloc(sizeof(struct htc_target), GFP_KERNEL);
 	if (!target) {
-		printk(KERN_ERR "Unable to allocate memory for"
+		printk(KERN_ERR "Unable to allocate memory for "
 			"target device\n");
 		return NULL;
 	}
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.h b/drivers/net/wireless/ath/ath9k/htc_hst.h
index 6fc1b21..02f4074 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.h
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.h
@@ -165,7 +165,7 @@ struct htc_service_connreq {
 
 /* Current service IDs */
 
-enum htc_service_group_ids{
+enum htc_service_group_ids {
 	RSVD_SERVICE_GROUP = 0,
 	WMI_SERVICE_GROUP = 1,
 
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 495432e..b309b68 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -287,7 +287,7 @@ static void ath_tx_return_buffer(struct ath_softc *sc, struct ath_buf *bf)
 	spin_unlock_bh(&sc->tx.txbuflock);
 }
 
-static struct ath_buf* ath_clone_txbuf(struct ath_softc *sc, struct ath_buf *bf)
+static struct ath_buf *ath_clone_txbuf(struct ath_softc *sc, struct ath_buf *bf)
 {
 	struct ath_buf *tbf;
 
@@ -666,7 +666,7 @@ static int ath_compute_num_delims(struct ath_softc *sc, struct ath_atx_tid *tid,
 		ndelim += ATH_AGGR_ENCRYPTDELIM;
 
 	/*
-	 * Convert desired mpdu density from microeconds to bytes based
+	 * Convert desired mpdu density from microseconds to bytes based
 	 * on highest rate in rate series (i.e. first rate) to determine
 	 * required minimum length for subframe. Take into account
 	 * whether high rate is 20 or 40Mhz and half or full GI.

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pma@sysgo.com>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	"ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>,
	kernel list <linux-kernel@vger.kernel.org>,
	"chunkeey@googlemail.com" <chunkeey@googlemail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"rudolf.marek@sysgo.com" <rudolf.marek@sysgo.com>,
	"cko@sysgo.com" <cko@sysgo.com>, "mfa@sysgo.com" <mfa@sysgo.com>,
	"anl@sysgo.com" <anl@sysgo.com>
Subject: [PATCH] ath9k_htc more cleanups
Date: Mon, 29 Nov 2010 12:34:53 +0100	[thread overview]
Message-ID: <20101129113453.GA29737@pma.sysgo.com> (raw)
In-Reply-To: <20101129095915.GB28833@pma.sysgo.com>

This fixes whitespace and fixes strings.

Signed-off-by: Pavel Machek <pma@sysgo.com>

diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c
index c41ab8c..ac4aed7 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.c
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.c
@@ -16,7 +16,7 @@
 
 #include "htc.h"
 
-static int htc_issue_send(struct htc_target *target, struct sk_buff* skb,
+static int htc_issue_send(struct htc_target *target, struct sk_buff *skb,
 			  u16 len, u8 flags, u8 epid,
 			  struct ath9k_htc_tx_ctl *tx_ctl)
 {
@@ -239,7 +239,7 @@ int htc_connect_service(struct htc_target *target,
 	/* Find an available endpoint */
 	endpoint = get_next_avail_ep(target->endpoint);
 	if (!endpoint) {
-		dev_err(target->dev, "Endpoint is not available for"
+		dev_err(target->dev, "Endpoint is not available for "
 			"service %d\n", service_connreq->service_id);
 		return -EINVAL;
 	}
@@ -253,7 +253,7 @@ int htc_connect_service(struct htc_target *target,
 	skb = alloc_skb(sizeof(struct htc_conn_svc_msg) +
 			    sizeof(struct htc_frame_hdr), GFP_ATOMIC);
 	if (!skb) {
-		dev_err(target->dev, "Failed to allocate buf to send"
+		dev_err(target->dev, "Failed to allocate buf to send "
 			"service connect req\n");
 		return -ENOMEM;
 	}
@@ -274,6 +274,7 @@ int htc_connect_service(struct htc_target *target,
 
 	time_left = wait_for_completion_timeout(&target->cmd_wait, HZ);
 	if (!time_left) {
+		/* who frees skb */
 		dev_err(target->dev, "Service connection timeout for: %d\n",
 			service_connreq->service_id);
 		return -ETIMEDOUT;
@@ -434,7 +435,7 @@ struct htc_target *ath9k_htc_hw_alloc(void *hif_handle,
 
 	target = kzalloc(sizeof(struct htc_target), GFP_KERNEL);
 	if (!target) {
-		printk(KERN_ERR "Unable to allocate memory for"
+		printk(KERN_ERR "Unable to allocate memory for "
 			"target device\n");
 		return NULL;
 	}
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.h b/drivers/net/wireless/ath/ath9k/htc_hst.h
index 6fc1b21..02f4074 100644
--- a/drivers/net/wireless/ath/ath9k/htc_hst.h
+++ b/drivers/net/wireless/ath/ath9k/htc_hst.h
@@ -165,7 +165,7 @@ struct htc_service_connreq {
 
 /* Current service IDs */
 
-enum htc_service_group_ids{
+enum htc_service_group_ids {
 	RSVD_SERVICE_GROUP = 0,
 	WMI_SERVICE_GROUP = 1,
 
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 495432e..b309b68 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -287,7 +287,7 @@ static void ath_tx_return_buffer(struct ath_softc *sc, struct ath_buf *bf)
 	spin_unlock_bh(&sc->tx.txbuflock);
 }
 
-static struct ath_buf* ath_clone_txbuf(struct ath_softc *sc, struct ath_buf *bf)
+static struct ath_buf *ath_clone_txbuf(struct ath_softc *sc, struct ath_buf *bf)
 {
 	struct ath_buf *tbf;
 
@@ -666,7 +666,7 @@ static int ath_compute_num_delims(struct ath_softc *sc, struct ath_atx_tid *tid,
 		ndelim += ATH_AGGR_ENCRYPTDELIM;
 
 	/*
-	 * Convert desired mpdu density from microeconds to bytes based
+	 * Convert desired mpdu density from microseconds to bytes based
 	 * on highest rate in rate series (i.e. first rate) to determine
 	 * required minimum length for subframe. Take into account
 	 * whether high rate is 20 or 40Mhz and half or full GI.


  reply	other threads:[~2010-11-29 11:34 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03  9:24 working usb wifi card, that is still possible to buy Pavel Machek
2010-11-05  9:26 ` Josh Lehan
2010-11-05 13:15   ` Larry Finger
2010-11-05 17:54     ` Johannes Berg
2010-11-05 20:12       ` Larry Finger
2010-11-06 10:43         ` Christian Lamparter
2010-11-08  7:19           ` Pavel Machek
2010-11-24  8:16 ` Pavel Machek
2010-11-24  8:42   ` Johannes Berg
2010-11-24  9:57     ` Pavel Machek
2010-11-24 13:13   ` Pavel Machek
2010-11-24 15:48     ` Larry Finger
2010-11-26  8:31       ` [ath9k-devel] ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy) Pavel Machek
2010-11-26  8:31         ` Pavel Machek
2010-11-26 10:20         ` [ath9k-devel] " Pavel Machek
2010-11-26 10:20           ` Pavel Machek
2010-11-26 11:27           ` [ath9k-devel] " Pavel Machek
2010-11-26 11:27             ` Pavel Machek
2010-11-26 11:35             ` [ath9k-devel] [PATCH] ath9k_htc: cleanup eeprom endiannes handling Pavel Machek
2010-11-26 11:35               ` Pavel Machek
2010-11-26 11:37             ` [ath9k-devel] [PATCH?] do structures need to be packed? [was Re: ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy)] Pavel Machek
2010-11-26 11:37               ` Pavel Machek
2010-11-26 11:47             ` [ath9k-devel] ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy) Sujith
2010-11-26 11:47               ` Sujith
2010-11-26 12:37               ` [ath9k-devel] " Pavel Machek
2010-11-26 12:37                 ` Pavel Machek
2010-11-29  9:58                 ` [ath9k-devel] [PATCH] fix endianity on ath9k_htc Pavel Machek
2010-11-29  9:58                   ` Pavel Machek
2010-11-29 11:46                   ` [ath9k-devel] " Felix Fietkau
2010-11-29 11:46                     ` Felix Fietkau
2010-11-29 12:07                     ` Pavel Machek
2010-11-29 12:07                       ` Pavel Machek
2010-11-29 12:11                       ` [ath9k-devel] [patch] remove unneeded prototype " Pavel Machek
2010-11-29 12:11                         ` Pavel Machek
2010-11-29  9:59                 ` [ath9k-devel] [PATCH] ath9k_htc cleanups Pavel Machek
2010-11-29  9:59                   ` Pavel Machek
2010-11-29 11:34                   ` Pavel Machek [this message]
2010-11-29 11:34                     ` [PATCH] ath9k_htc more cleanups Pavel Machek
2010-11-29 10:01                 ` [ath9k-devel] ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy) Pavel Machek
2010-11-29 10:01                   ` Pavel Machek
2010-11-29 12:37                   ` [ath9k-devel] " Sujith
2010-11-29 12:37                     ` Sujith
2010-11-29 12:48                     ` [ath9k-devel] " Pavel Machek
2010-11-29 12:48                       ` Pavel Machek
2010-11-29 12:57                     ` [ath9k-devel] " Pavel Machek
2010-11-29 12:57                       ` Pavel Machek
2010-11-29 13:28                       ` [ath9k-devel] " Sujith
2010-11-29 13:28                         ` Sujith
2010-11-29 12:16                 ` [ath9k-devel] " Sujith
2010-11-29 12:16                   ` Sujith
2010-12-06  8:37     ` working usb wifi card, that is still possible to buy Pavel Machek
2010-12-06 15:30       ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129113453.GA29737@pma.sysgo.com \
    --to=pma@sysgo.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.