From: Wei Wang2 <wei.wang2@amd.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] hvm passthru: Fix a xen-unstable crash
Date: Mon, 29 Nov 2010 17:47:09 +0100 [thread overview]
Message-ID: <201011291747.09794.wei.wang2@amd.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1011291547230.14723@kaball-desktop>
On Monday 29 November 2010 16:49:05 Stefano Stabellini wrote:
> On Mon, 29 Nov 2010, Keir Fraser wrote:
> > Stefano,
> >
> > Can you ack/nack this patch please.
>
> ack.
>
> I think we also need this:
>
>
> diff -r 79b71c77907b xen/arch/x86/physdev.c
> --- a/xen/arch/x86/physdev.c Wed Nov 24 10:20:03 2010 +0000
> +++ b/xen/arch/x86/physdev.c Mon Nov 29 15:26:03 2010 +0000
> @@ -236,7 +236,8 @@ static int physdev_unmap_pirq(struct phy
> spin_lock(&d->event_lock);
> ret = unmap_domain_pirq_emuirq(d, unmap->pirq);
> spin_unlock(&d->event_lock);
> - goto free_domain;
> + if ( unmap->domid == DOMID_SELF || ret )
> + goto free_domain;
> }
>
> ret = -EPERM;
>
>
> Wei, could you give it a try, in addition to your patch?
>
> Thanks,
>
> Stefano
Hi Stefano,
This patch works well together with my patch on our testing system. No more
crashes.
Thanks,
Wei
next prev parent reply other threads:[~2010-11-29 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 14:34 [PATCH] hvm passthru: Fix a xen-unstable crash Wei Wang2
2010-11-29 14:48 ` Keir Fraser
2010-11-29 15:49 ` Stefano Stabellini
2010-11-29 16:47 ` Wei Wang2 [this message]
2010-11-29 17:32 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011291747.09794.wei.wang2@amd.com \
--to=wei.wang2@amd.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.