From: Shaohui Zheng <shaohui.zheng@intel.com>
To: Valdis.Kletnieks@vt.edu
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
lethal@linux-sh.org, ak@linux.intel.com,
shaohui.zheng@linux.intel.com, rientjes@google.com,
dave@linux.vnet.ibm.com, gregkh@suse.de,
Haicheng Li <haicheng.li@intel.com>
Subject: Re: [8/8, v5] NUMA Hotplug Emulator: documentation
Date: Tue, 30 Nov 2010 09:31:21 +0800 [thread overview]
Message-ID: <20101130013121.GC3021@shaohui> (raw)
In-Reply-To: <14037.1291054756@localhost>
On Mon, Nov 29, 2010 at 01:19:16PM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 29 Nov 2010 17:17:58 +0800, shaohui.zheng@intel.com said:
> > From: Shaohui Zheng <shaohui.zheng@intel.com>
> >
> > add a text file Documentation/x86/x86_64/numa_hotplug_emulator.txt
> > to explain the usage for the hotplug emulator.
>
> Can you renumber this to 1/8 if you resubmit it? It helps code review if you
> already know what it's *intended* to do beforehand. It also helps drinking
> from the lkml firehose if you can read 0/N and 1/N and know if it's something
> you want to review, otherwise you read 0/N, have to go find N/N, read that,
> then go back and delete 1/N through N-1/N.
>
> (Sometimes, the 0/N cover isn't enough - reading the documentation actually
> fills in enough blanks to make you go "Wow, this *is* applicable to something
> I'm working on...")
When I send the previous version, I always add the full documentation in 0/N
patches. The feedbacks, suggestions, and modifications are all included in 0/N
patch. it makes it as a very long text, so I decide to remove the full documentation
from 0/N since we already send these docs in early version, it get the 0/N patch
much smaller.
I will still keep the full documentation in 0/N, and renumber 8/8 to 1/8. Thanks
for the remind.
--
Thanks & Regards,
Shaohui
WARNING: multiple messages have this Message-ID (diff)
From: Shaohui Zheng <shaohui.zheng@intel.com>
To: Valdis.Kletnieks@vt.edu
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
lethal@linux-sh.org, ak@linux.intel.com,
shaohui.zheng@linux.intel.com, rientjes@google.com,
dave@linux.vnet.ibm.com, gregkh@suse.de,
Haicheng Li <haicheng.li@intel.com>
Subject: Re: [8/8, v5] NUMA Hotplug Emulator: documentation
Date: Tue, 30 Nov 2010 09:31:21 +0800 [thread overview]
Message-ID: <20101130013121.GC3021@shaohui> (raw)
In-Reply-To: <14037.1291054756@localhost>
On Mon, Nov 29, 2010 at 01:19:16PM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 29 Nov 2010 17:17:58 +0800, shaohui.zheng@intel.com said:
> > From: Shaohui Zheng <shaohui.zheng@intel.com>
> >
> > add a text file Documentation/x86/x86_64/numa_hotplug_emulator.txt
> > to explain the usage for the hotplug emulator.
>
> Can you renumber this to 1/8 if you resubmit it? It helps code review if you
> already know what it's *intended* to do beforehand. It also helps drinking
> from the lkml firehose if you can read 0/N and 1/N and know if it's something
> you want to review, otherwise you read 0/N, have to go find N/N, read that,
> then go back and delete 1/N through N-1/N.
>
> (Sometimes, the 0/N cover isn't enough - reading the documentation actually
> fills in enough blanks to make you go "Wow, this *is* applicable to something
> I'm working on...")
When I send the previous version, I always add the full documentation in 0/N
patches. The feedbacks, suggestions, and modifications are all included in 0/N
patch. it makes it as a very long text, so I decide to remove the full documentation
from 0/N since we already send these docs in early version, it get the 0/N patch
much smaller.
I will still keep the full documentation in 0/N, and renumber 8/8 to 1/8. Thanks
for the remind.
--
Thanks & Regards,
Shaohui
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-30 2:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 9:17 [0/8, v5] NUMA Hotplug Emulator(v5) - Feedbacks & Responses shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 9:17 ` [1/8, v5] NUMA Hotplug Emulator: Add numa=possibe options shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 23:59 ` David Rientjes
2010-11-29 23:59 ` David Rientjes
2010-11-30 1:09 ` Shaohui Zheng
2010-11-30 1:09 ` Shaohui Zheng
2010-11-29 9:17 ` [2/8, v5] NUMA Hotplug Emulator: Add node hotplug emulation shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-30 0:01 ` David Rientjes
2010-11-30 0:01 ` David Rientjes
2010-11-30 1:22 ` Shaohui Zheng
2010-11-30 1:22 ` Shaohui Zheng
2010-11-30 20:10 ` David Rientjes
2010-11-30 20:10 ` David Rientjes
2010-11-30 23:16 ` Shaohui Zheng
2010-11-30 23:16 ` Shaohui Zheng
2010-12-02 0:59 ` David Rientjes
2010-12-02 0:59 ` David Rientjes
2010-11-29 9:17 ` [3/8, v5] NUMA Hotplug Emulation: Abstract cpu register functions shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 9:17 ` [4/8, v5] NUMA Hotplug Emulator: support cpu probe/release in x86_64 shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 9:17 ` [5/8, v5] NUMA Hotplug Emulator: Fake CPU socket with logical CPU on x86 shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 9:17 ` [6/8, v5] From: Shaohui Zheng <shaohui.zheng@intel.com> shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 9:17 ` [7/8, v5] NUMA Hotplug Emulator: implement debugfs interface for memory probe shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 9:17 ` [8/8, v5] NUMA Hotplug Emulator: documentation shaohui.zheng
2010-11-29 9:17 ` shaohui.zheng
2010-11-29 18:19 ` Valdis.Kletnieks
2010-11-30 1:31 ` Shaohui Zheng [this message]
2010-11-30 1:31 ` Shaohui Zheng
2010-11-30 0:02 ` David Rientjes
2010-11-30 0:02 ` David Rientjes
2010-11-30 1:32 ` Shaohui Zheng
2010-11-30 1:32 ` Shaohui Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130013121.GC3021@shaohui \
--to=shaohui.zheng@intel.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=haicheng.li@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=shaohui.zheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.