From: Dave Chinner <david@fromorbit.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] lib: percpu counter add unless less than functionality
Date: Tue, 30 Nov 2010 15:30:01 +1100 [thread overview]
Message-ID: <20101130043001.GC3556@dastard> (raw)
In-Reply-To: <1291032530.32004.26.camel@laptop>
On Mon, Nov 29, 2010 at 01:08:50PM +0100, Peter Zijlstra wrote:
> On Mon, 2010-11-29 at 11:36 +1100, Dave Chinner wrote:
> > +int percpu_counter_add_unless_lt(struct percpu_counter *fbc, s64 amount,
> > + s64 threshold);
>
> It might make sense to implement that as;
>
> __percpu_counter_add_unless_lt(struct percpu_counter *fbc,
> s64 amount,
> s64 threshold,
> s32 batch);
>
> That way its consistent with the __percpu_counter_add() implementation
> where you can also specify the batch value.
Good point. I'll fix that up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] lib: percpu counter add unless less than functionality
Date: Tue, 30 Nov 2010 15:30:01 +1100 [thread overview]
Message-ID: <20101130043001.GC3556@dastard> (raw)
In-Reply-To: <1291032530.32004.26.camel@laptop>
On Mon, Nov 29, 2010 at 01:08:50PM +0100, Peter Zijlstra wrote:
> On Mon, 2010-11-29 at 11:36 +1100, Dave Chinner wrote:
> > +int percpu_counter_add_unless_lt(struct percpu_counter *fbc, s64 amount,
> > + s64 threshold);
>
> It might make sense to implement that as;
>
> __percpu_counter_add_unless_lt(struct percpu_counter *fbc,
> s64 amount,
> s64 threshold,
> s32 batch);
>
> That way its consistent with the __percpu_counter_add() implementation
> where you can also specify the batch value.
Good point. I'll fix that up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-11-30 4:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 0:36 [PATCH 0/3] Use generic percpu counters in XFS Dave Chinner
2010-11-29 0:36 ` Dave Chinner
2010-11-29 0:36 ` [PATCH 1/3] lib: percpu counter add unless less than functionality Dave Chinner
2010-11-29 0:36 ` Dave Chinner
2010-11-29 12:08 ` Peter Zijlstra
2010-11-29 12:08 ` Peter Zijlstra
2010-11-30 4:30 ` Dave Chinner [this message]
2010-11-30 4:30 ` Dave Chinner
2010-11-29 0:36 ` [PATCH 2/3] xfs: use generic per-cpu counter infrastructure Dave Chinner
2010-11-29 0:36 ` Dave Chinner
2010-11-29 9:16 ` Christoph Hellwig
2010-11-29 9:16 ` Christoph Hellwig
2010-11-30 4:37 ` Dave Chinner
2010-11-30 4:37 ` Dave Chinner
2010-11-29 0:36 ` [PATCH 3/3] xfs: demultiplex xfs_icsb_modify_counters() Dave Chinner
2010-11-29 0:36 ` Dave Chinner
2010-11-29 9:19 ` Christoph Hellwig
2010-11-29 9:19 ` Christoph Hellwig
2010-11-30 4:38 ` Dave Chinner
2010-11-30 4:38 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2010-12-13 1:21 [PATCH 0/3] Use generic percpu counters in XFS V2 Dave Chinner
2010-12-13 1:21 ` [PATCH 1/3] lib: percpu counter add unless less than functionality Dave Chinner
2010-12-13 1:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130043001.GC3556@dastard \
--to=david@fromorbit.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.