From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 5/5] ASoC: tpa6130a2: Make DAPM registration optional, and direct interface
Date: Tue, 30 Nov 2010 14:30:13 +0000 [thread overview]
Message-ID: <20101130143013.GM7403@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291125604-10396-6-git-send-email-peter.ujfalusi@nokia.com>
On Tue, Nov 30, 2010 at 04:00:04PM +0200, Peter Ujfalusi wrote:
> Users can choose to not add the DAPM routes provided by the
> amp driver, but use the direct enable/disable interface
> from machine driver with SND_SOC_DAPM_HP's event callback.
> In some cases this method must be used to make the audio
> path pop noise free.
Is there any situation where it would undesirable to do this? If not
it'd seem better to just make the driver do this always.
> +int tpa6130a2_stereo_enable(int enable)
> +{
It'd be much nicer if this took a CODEC as an argument - even if the
implementation doesn't actually use it yet it'd be better to have an
interface which has an idea that there may be multiple instances of the
device.
next prev parent reply other threads:[~2010-11-30 14:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 13:59 [PATCH 0/5] ASoC: tpa6130a2: pop removal (mostly) changes Peter Ujfalusi
2010-11-30 14:00 ` [PATCH 1/5] ASoC: tpa6130a2: Simplify power state management Peter Ujfalusi
2010-11-30 14:24 ` Mark Brown
2010-11-30 14:00 ` [PATCH 2/5] ASoC: tpa6130a2: Defer SW enable from power enable Peter Ujfalusi
2010-11-30 14:24 ` Mark Brown
2010-11-30 14:00 ` [PATCH 3/5] ASoC: tpa6130a2: Use one event handler for PGA_E Peter Ujfalusi
2010-11-30 14:25 ` Mark Brown
2010-11-30 14:00 ` [PATCH 4/5] ASoC: tpa6130a2: Add stereo DAPM path Peter Ujfalusi
2010-11-30 14:26 ` Mark Brown
2010-11-30 14:00 ` [PATCH 5/5] ASoC: tpa6130a2: Make DAPM registration optional, and direct interface Peter Ujfalusi
2010-11-30 14:30 ` Mark Brown [this message]
2010-12-01 6:54 ` Peter Ujfalusi
2010-12-01 8:07 ` Peter Ujfalusi
2010-12-01 11:44 ` Mark Brown
2010-12-02 7:06 ` Peter Ujfalusi
2010-11-30 15:45 ` [PATCH 0/5] ASoC: tpa6130a2: pop removal (mostly) changes Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130143013.GM7403@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.