From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 5/5] ASoC: tpa6130a2: Make DAPM registration optional, and direct interface
Date: Thu, 2 Dec 2010 09:06:26 +0200 [thread overview]
Message-ID: <201012020906.26841.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20101201114427.GB5688@sirena.org.uk>
On Wednesday 01 December 2010 13:44:28 ext Mark Brown wrote:
> You didn't mention any pop/click issues in the original patch or the
> discussion following it as far as I remember - in your original patch
> there was nothing motivating doing this
Correct. At that time I did not noticed this problem, and with that HW setup it
was OK. With different components however the ordering is a problem.
I only had chance/time to look for pop noise recently...
> I think this is a better approach since it solves an actual problem. We
> may want to consider introducing a new widget type for edge PGAs, though
> I can see that getting overused.
Thanks, I'll send a patch to remove the DAPM things from the tpa driver.
It's a shame, sicne the DAPM things inside of the driver looks quite nice after
the series ;)
--
Péter
next prev parent reply other threads:[~2010-12-02 7:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 13:59 [PATCH 0/5] ASoC: tpa6130a2: pop removal (mostly) changes Peter Ujfalusi
2010-11-30 14:00 ` [PATCH 1/5] ASoC: tpa6130a2: Simplify power state management Peter Ujfalusi
2010-11-30 14:24 ` Mark Brown
2010-11-30 14:00 ` [PATCH 2/5] ASoC: tpa6130a2: Defer SW enable from power enable Peter Ujfalusi
2010-11-30 14:24 ` Mark Brown
2010-11-30 14:00 ` [PATCH 3/5] ASoC: tpa6130a2: Use one event handler for PGA_E Peter Ujfalusi
2010-11-30 14:25 ` Mark Brown
2010-11-30 14:00 ` [PATCH 4/5] ASoC: tpa6130a2: Add stereo DAPM path Peter Ujfalusi
2010-11-30 14:26 ` Mark Brown
2010-11-30 14:00 ` [PATCH 5/5] ASoC: tpa6130a2: Make DAPM registration optional, and direct interface Peter Ujfalusi
2010-11-30 14:30 ` Mark Brown
2010-12-01 6:54 ` Peter Ujfalusi
2010-12-01 8:07 ` Peter Ujfalusi
2010-12-01 11:44 ` Mark Brown
2010-12-02 7:06 ` Peter Ujfalusi [this message]
2010-11-30 15:45 ` [PATCH 0/5] ASoC: tpa6130a2: pop removal (mostly) changes Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012020906.26841.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.