All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@mvista.com>
To: Russell King <linux@arm.linux.org.uk>
Cc: "Tony Lindgren" <tony@atomide.com>,
	"Kukjin Kim" <kgene.kim@samsung.com>,
	"Colin Cross" <ccross@android.com>,
	"Srinidhi Kasagar" <srinidhi.kasagar@stericsson.com>,
	"Jamie Iles" <jamie.iles@picochip.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH 8/8] ARM: OMAP2: Switch to generic SCU routines
Date: Tue, 30 Nov 2010 20:17:12 +0300	[thread overview]
Message-ID: <20101130171712.GH24034@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20101130171626.GA6165@oksana.dev.rtsoft.ru>

This shrinks platform-specific code a little bit.

Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
---
 arch/arm/mach-omap2/omap-smp.c |   64 ++--------------------------------------
 1 files changed, 3 insertions(+), 61 deletions(-)

diff --git a/arch/arm/mach-omap2/omap-smp.c b/arch/arm/mach-omap2/omap-smp.c
index 56a8bce..52379c7 100644
--- a/arch/arm/mach-omap2/omap-smp.c
+++ b/arch/arm/mach-omap2/omap-smp.c
@@ -29,16 +29,6 @@
 /* SCU base address */
 static void __iomem *scu_base;
 
-/*
- * Use SCU config register to count number of cores
- */
-static inline unsigned int get_core_count(void)
-{
-	if (scu_base)
-		return scu_get_core_count(scu_base);
-	return 1;
-}
-
 static DEFINE_SPINLOCK(boot_lock);
 
 void __cpuinit platform_secondary_init(unsigned int cpu)
@@ -112,65 +102,17 @@ static void __init wakeup_secondary(void)
  */
 void __init smp_init_cpus(void)
 {
-	unsigned int i, ncores;
-
 	/* Never released */
 	scu_base = ioremap(OMAP44XX_SCU_BASE, SZ_256);
 	BUG_ON(!scu_base);
 
-	ncores = get_core_count();
-
-	for (i = 0; i < ncores; i++)
-		set_cpu_possible(i, true);
+	scu_init_cpus(scu_base);
 }
 
 void __init smp_prepare_cpus(unsigned int max_cpus)
 {
-	unsigned int ncores = get_core_count();
-	unsigned int cpu = smp_processor_id();
-	int i;
-
-	/* sanity check */
-	if (ncores == 0) {
-		printk(KERN_ERR
-		       "OMAP4: strange core count of 0? Default to 1\n");
-		ncores = 1;
-	}
-
-	if (ncores > NR_CPUS) {
-		printk(KERN_WARNING
-		       "OMAP4: no. of cores (%d) greater than configured "
-		       "maximum of %d - clipping\n",
-		       ncores, NR_CPUS);
-		ncores = NR_CPUS;
-	}
-	smp_store_cpu_info(cpu);
-
-	/*
-	 * are we trying to boot more cores than exist?
-	 */
-	if (max_cpus > ncores)
-		max_cpus = ncores;
+	scu_prepare_cpus(scu_base, max_cpus);
 
-	/*
-	 * Initialise the present map, which describes the set of CPUs
-	 * actually populated at the present time.
-	 */
-	for (i = 0; i < max_cpus; i++)
-		set_cpu_present(i, true);
-
-	if (max_cpus > 1) {
-		/*
-		 * Enable the local timer or broadcast device for the
-		 * boot CPU, but only if we have more than one CPU.
-		 */
-		percpu_timer_setup();
-
-		/*
-		 * Initialise the SCU and wake up the secondary core using
-		 * wakeup_secondary().
-		 */
-		scu_enable(scu_base);
+	if (max_cpus > 1)
 		wakeup_secondary();
-	}
 }
-- 
1.7.0.5

WARNING: multiple messages have this Message-ID (diff)
From: avorontsov@mvista.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] ARM: OMAP2: Switch to generic SCU routines
Date: Tue, 30 Nov 2010 20:17:12 +0300	[thread overview]
Message-ID: <20101130171712.GH24034@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20101130171626.GA6165@oksana.dev.rtsoft.ru>

This shrinks platform-specific code a little bit.

Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
---
 arch/arm/mach-omap2/omap-smp.c |   64 ++--------------------------------------
 1 files changed, 3 insertions(+), 61 deletions(-)

diff --git a/arch/arm/mach-omap2/omap-smp.c b/arch/arm/mach-omap2/omap-smp.c
index 56a8bce..52379c7 100644
--- a/arch/arm/mach-omap2/omap-smp.c
+++ b/arch/arm/mach-omap2/omap-smp.c
@@ -29,16 +29,6 @@
 /* SCU base address */
 static void __iomem *scu_base;
 
-/*
- * Use SCU config register to count number of cores
- */
-static inline unsigned int get_core_count(void)
-{
-	if (scu_base)
-		return scu_get_core_count(scu_base);
-	return 1;
-}
-
 static DEFINE_SPINLOCK(boot_lock);
 
 void __cpuinit platform_secondary_init(unsigned int cpu)
@@ -112,65 +102,17 @@ static void __init wakeup_secondary(void)
  */
 void __init smp_init_cpus(void)
 {
-	unsigned int i, ncores;
-
 	/* Never released */
 	scu_base = ioremap(OMAP44XX_SCU_BASE, SZ_256);
 	BUG_ON(!scu_base);
 
-	ncores = get_core_count();
-
-	for (i = 0; i < ncores; i++)
-		set_cpu_possible(i, true);
+	scu_init_cpus(scu_base);
 }
 
 void __init smp_prepare_cpus(unsigned int max_cpus)
 {
-	unsigned int ncores = get_core_count();
-	unsigned int cpu = smp_processor_id();
-	int i;
-
-	/* sanity check */
-	if (ncores == 0) {
-		printk(KERN_ERR
-		       "OMAP4: strange core count of 0? Default to 1\n");
-		ncores = 1;
-	}
-
-	if (ncores > NR_CPUS) {
-		printk(KERN_WARNING
-		       "OMAP4: no. of cores (%d) greater than configured "
-		       "maximum of %d - clipping\n",
-		       ncores, NR_CPUS);
-		ncores = NR_CPUS;
-	}
-	smp_store_cpu_info(cpu);
-
-	/*
-	 * are we trying to boot more cores than exist?
-	 */
-	if (max_cpus > ncores)
-		max_cpus = ncores;
+	scu_prepare_cpus(scu_base, max_cpus);
 
-	/*
-	 * Initialise the present map, which describes the set of CPUs
-	 * actually populated at the present time.
-	 */
-	for (i = 0; i < max_cpus; i++)
-		set_cpu_present(i, true);
-
-	if (max_cpus > 1) {
-		/*
-		 * Enable the local timer or broadcast device for the
-		 * boot CPU, but only if we have more than one CPU.
-		 */
-		percpu_timer_setup();
-
-		/*
-		 * Initialise the SCU and wake up the secondary core using
-		 * wakeup_secondary().
-		 */
-		scu_enable(scu_base);
+	if (max_cpus > 1)
 		wakeup_secondary();
-	}
 }
-- 
1.7.0.5

  parent reply	other threads:[~2010-11-30 17:17 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 17:16 [PATCH v4 0/8] SMP support for CNS3xxx + some SMP SCU cleanups Anton Vorontsov
2010-11-30 17:16 ` Anton Vorontsov
2010-11-30 17:16 ` [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup Anton Vorontsov
2010-11-30 17:16   ` Anton Vorontsov
2010-11-30 17:16   ` Anton Vorontsov
2010-11-30 22:24   ` Russell King - ARM Linux
2010-11-30 22:24     ` Russell King - ARM Linux
2010-11-30 23:32   ` Russell King - ARM Linux
2010-11-30 23:32     ` Russell King - ARM Linux
2010-12-01  0:25     ` Russell King - ARM Linux
2010-12-01  0:25       ` Russell King - ARM Linux
2010-12-02 15:19       ` Catalin Marinas
2010-12-02 15:19         ` Catalin Marinas
2010-12-02 15:19         ` Catalin Marinas
2010-12-02 15:24         ` Russell King - ARM Linux
2010-12-02 15:24           ` Russell King - ARM Linux
2010-12-02 16:28           ` Catalin Marinas
2010-12-02 16:28             ` Catalin Marinas
2010-12-02 17:38             ` Russell King - ARM Linux
2010-12-02 17:38               ` Russell King - ARM Linux
2010-12-02 17:55               ` Catalin Marinas
2010-12-02 17:55                 ` Catalin Marinas
2010-12-02 18:01               ` Russell King - ARM Linux
2010-12-02 18:01                 ` Russell King - ARM Linux
2010-12-04  8:48                 ` Russell King - ARM Linux
2010-12-04  8:48                 ` Russell King - ARM Linux
2010-12-04  8:48                   ` Russell King - ARM Linux
2010-12-04  8:48                   ` Russell King - ARM Linux
2010-12-06  7:28                   ` [PATCH 1/8] ARM: SCU: Add common routines for secondary CPUbootup Santosh Shilimkar
2010-12-06  7:28                     ` Santosh Shilimkar
2010-12-06  7:28                     ` Santosh Shilimkar
2010-12-06  7:28                   ` Santosh Shilimkar
2010-12-01  6:21     ` [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup Srinidhi Kasagar
2010-12-01  6:21       ` Srinidhi Kasagar
2010-11-30 17:17 ` [PATCH 2/8] ARM: cns3xxx: Add support for SMP Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 18:14   ` Russell King - ARM Linux
2010-11-30 18:14     ` Russell King - ARM Linux
2010-11-30 17:17 ` [PATCH 3/8] ARM: VExpress: Switch to generic SCU routines Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 23:27   ` Russell King - ARM Linux
2010-11-30 23:27     ` Russell King - ARM Linux
2010-11-30 17:17 ` [PATCH 4/8] ARM: RealView: " Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 17:17 ` [PATCH 5/8] ARM: S5PV310: " Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 17:17 ` [PATCH 6/8] ARM: ux500: " Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 17:17 ` [PATCH 7/8] ARM: tegra: " Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 17:17   ` Anton Vorontsov
2010-11-30 17:17 ` Anton Vorontsov [this message]
2010-11-30 17:17   ` [PATCH 8/8] ARM: OMAP2: " Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101130171712.GH24034@oksana.dev.rtsoft.ru \
    --to=avorontsov@mvista.com \
    --cc=catalin.marinas@arm.com \
    --cc=ccross@android.com \
    --cc=jamie.iles@picochip.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=srinidhi.kasagar@stericsson.com \
    --cc=tony@atomide.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.