All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Chris Wright <chrisw@sous-sol.org>,
	Max Asbock <masbock@linux.vnet.ibm.com>,
	indou.takao@jp.fujitsu.com,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	stable@kernel.org
Subject: [patch 4/4] vt-d: handle previous faults after enabling fault handling
Date: Tue, 30 Nov 2010 22:22:29 -0800	[thread overview]
Message-ID: <20101201062244.630417138@intel.com> (raw)
In-Reply-To: 20101201062225.292364637@intel.com

[-- Attachment #1: vtd_handle_oldfaults_in_enable_drhd_fault_handling.patch --]
[-- Type: text/plain, Size: 1132 bytes --]

Fault handling is getting enabled after enabling the interrupt-remapping (as
the success of interrupt-remapping can affect the apic mode and hence the
fault handling mode).

Hence there can potentially be some faults between the window of enabling
interrupt-remapping in the vt-d and the fault-handling of the vt-d units.

Handle any previous faults after enabling the vt-d fault handling.

For v2.6.38 cleanup, need to check if we can remove the dmar_fault() in the
enable_intr_remapping() and see if we can enable fault handling along with
enabling intr-remapping.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: stable@kernel.org [v2.6.32+]
---
 drivers/pci/dmar.c |    5 +++++
 1 file changed, 5 insertions(+)

Index: tip/drivers/pci/dmar.c
===================================================================
--- tip.orig/drivers/pci/dmar.c
+++ tip/drivers/pci/dmar.c
@@ -1417,6 +1417,11 @@ int __init enable_drhd_fault_handling(vo
 			       (unsigned long long)drhd->reg_base_addr, ret);
 			return -1;
 		}
+
+		/*
+ 		 * Clear any previous faults.
+ 		 */
+		dmar_fault(iommu->irq, iommu);
 	}
 
 	return 0;



  parent reply	other threads:[~2010-12-01  6:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01  6:22 [patch 0/4] x86, intr-remapping patches for addressing kexec/kdump issues Suresh Siddha
2010-12-01  6:22 ` [patch 1/4] vt-d: quirk for masking vtd spec errors to platform error handling logic Suresh Siddha
2010-12-01  7:26   ` Chris Wright
2010-12-06 17:27   ` Jesse Barnes
2010-12-06 20:26     ` Suresh Siddha
2010-12-06 20:44       ` Jesse Barnes
2010-12-06 21:02         ` Suresh Siddha
2010-12-06 23:01           ` Max Asbock
2010-12-14  1:15       ` [tip:x86/urgent] x86, vt-d: Quirk " tip-bot for Suresh Siddha
2010-12-01  6:22 ` [patch 2/4] x86, vtd: fix the vt-d fault handling irq migration in the x2apic mode Suresh Siddha
2010-12-01  8:52   ` Chris Wright
2010-12-01 15:14   ` Bjorn Helgaas
2010-12-01 17:40     ` Suresh Siddha
2010-12-07 17:38       ` Takao Indoh
2010-12-14  1:16       ` [tip:x86/urgent] x86, vt-d: Fix " tip-bot for Kenji Kaneshige
2010-12-01  6:22 ` [patch 3/4] x86: enable the intr-remap fault handling after local apic setup Suresh Siddha
2010-12-01  8:51   ` Chris Wright
2010-12-14  1:16   ` [tip:x86/urgent] x86: Enable the intr-remap fault handling after local APIC setup tip-bot for Kenji Kaneshige
2010-12-01  6:22 ` Suresh Siddha [this message]
2010-12-01  8:52   ` [patch 4/4] vt-d: handle previous faults after enabling fault handling Chris Wright
2010-12-14  1:17   ` [tip:x86/urgent] x86, vt-d: Handle " tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101201062244.630417138@intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=chrisw@sous-sol.org \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masbock@linux.vnet.ibm.com \
    --cc=mingo@redhat.com \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.