* [PATCH] ASoC: WM8731: Fix incorrect mask for bypass path disable
@ 2010-12-01 9:38 Dimitris Papastamos
2010-12-01 9:54 ` Liam Girdwood
2010-12-01 11:29 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dimitris Papastamos @ 2010-12-01 9:38 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches
According to the datasheet the bypass path enable/disable is
bit 3 therefore we need 0x8 and not 0x4.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8731.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index a104145..94e0cf3 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -526,7 +526,7 @@ static int wm8731_probe(struct snd_soc_codec *codec)
snd_soc_update_bits(codec, WM8731_RINVOL, 0x100, 0);
/* Disable bypass path by default */
- snd_soc_update_bits(codec, WM8731_APANA, 0x4, 0);
+ snd_soc_update_bits(codec, WM8731_APANA, 0x8, 0);
snd_soc_add_controls(codec, wm8731_snd_controls,
ARRAY_SIZE(wm8731_snd_controls));
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8731: Fix incorrect mask for bypass path disable
2010-12-01 9:38 [PATCH] ASoC: WM8731: Fix incorrect mask for bypass path disable Dimitris Papastamos
@ 2010-12-01 9:54 ` Liam Girdwood
2010-12-01 11:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-12-01 9:54 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, Mark Brown, patches
On Wed, 2010-12-01 at 09:38 +0000, Dimitris Papastamos wrote:
> According to the datasheet the bypass path enable/disable is
> bit 3 therefore we need 0x8 and not 0x4.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: WM8731: Fix incorrect mask for bypass path disable
2010-12-01 9:38 [PATCH] ASoC: WM8731: Fix incorrect mask for bypass path disable Dimitris Papastamos
2010-12-01 9:54 ` Liam Girdwood
@ 2010-12-01 11:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-12-01 11:29 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood
On Wed, Dec 01, 2010 at 09:38:55AM +0000, Dimitris Papastamos wrote:
> According to the datasheet the bypass path enable/disable is
> bit 3 therefore we need 0x8 and not 0x4.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-01 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-01 9:38 [PATCH] ASoC: WM8731: Fix incorrect mask for bypass path disable Dimitris Papastamos
2010-12-01 9:54 ` Liam Girdwood
2010-12-01 11:29 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.