All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohui Zheng <shaohui.zheng@intel.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
	lethal@linux-sh.org, ak@linux.intel.com,
	shaohui.zheng@linux.intel.com, dave@linux.vnet.ibm.com,
	gregkh@suse.de, Haicheng Li <haicheng.li@intel.com>
Subject: Re: [8/8, v6] NUMA Hotplug Emulator: implement debugfs interface for memory probe
Date: Thu, 2 Dec 2010 07:45:14 +0800	[thread overview]
Message-ID: <20101201234514.GA13509@shaohui> (raw)
In-Reply-To: <alpine.DEB.2.00.1012011656590.1896@chino.kir.corp.google.com>

On Wed, Dec 01, 2010 at 04:57:35PM -0800, David Rientjes wrote:
> On Tue, 30 Nov 2010, shaohui.zheng@intel.com wrote:
> 
> > From: Shaohui Zheng <shaohui.zheng@intel.com>
> > 
> > Implement a debugfs inteface /sys/kernel/debug/mem_hotplug/probe for meomory hotplug
> > emulation.  it accepts the same parameters like
> > /sys/devices/system/memory/probe.
> > 
> 
> NACK, we don't need two interfaces to do the same thing.  

You may not know the background, the sysfs memory/probe interface is a general
interface.  Even through we have a debugfs interface, we should still keep it.

For test purpose, the sysfs is enough, according to the comments from Greg & Dave,
we create the debugfs interface.

-- 
Thanks & Regards,
Shaohui


WARNING: multiple messages have this Message-ID (diff)
From: Shaohui Zheng <shaohui.zheng@intel.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
	lethal@linux-sh.org, ak@linux.intel.com,
	shaohui.zheng@linux.intel.com, dave@linux.vnet.ibm.com,
	gregkh@suse.de, Haicheng Li <haicheng.li@intel.com>
Subject: Re: [8/8, v6] NUMA Hotplug Emulator: implement debugfs interface for memory probe
Date: Thu, 2 Dec 2010 07:45:14 +0800	[thread overview]
Message-ID: <20101201234514.GA13509@shaohui> (raw)
In-Reply-To: <alpine.DEB.2.00.1012011656590.1896@chino.kir.corp.google.com>

On Wed, Dec 01, 2010 at 04:57:35PM -0800, David Rientjes wrote:
> On Tue, 30 Nov 2010, shaohui.zheng@intel.com wrote:
> 
> > From: Shaohui Zheng <shaohui.zheng@intel.com>
> > 
> > Implement a debugfs inteface /sys/kernel/debug/mem_hotplug/probe for meomory hotplug
> > emulation.  it accepts the same parameters like
> > /sys/devices/system/memory/probe.
> > 
> 
> NACK, we don't need two interfaces to do the same thing.  

You may not know the background, the sysfs memory/probe interface is a general
interface.  Even through we have a debugfs interface, we should still keep it.

For test purpose, the sysfs is enough, according to the comments from Greg & Dave,
we create the debugfs interface.

-- 
Thanks & Regards,
Shaohui

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-12-02  1:08 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30  7:13 [0/8, v6] NUMA Hotplug Emulator(v6) - Introduction & Feedbacks shaohui.zheng
2010-11-30  7:13 ` shaohui.zheng
2010-11-30  7:13 ` [1/8, v6] NUMA Hotplug Emulator: documentation shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-12-01  0:19   ` David Rientjes
2010-12-01  0:19     ` David Rientjes
2010-12-01  0:36     ` Shaohui Zheng
2010-12-01  0:36       ` Shaohui Zheng
2010-11-30  7:13 ` [2/8, v6] NUMA Hotplug Emulator: Add numa=possible option shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-12-02  1:06   ` David Rientjes
2010-12-02  1:06     ` David Rientjes
2010-12-01 23:48     ` Shaohui Zheng
2010-12-01 23:48       ` Shaohui Zheng
2010-11-30  7:13 ` [3/8, v6] NUMA Hotplug Emulator: Add node hotplug emulation shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-11-30  7:13 ` [4/8, v6] NUMA Hotplug Emulation: Abstract cpu register functions shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-11-30  7:13 ` [5/8, v6] NUMA Hotplug Emulator: support cpu probe/release in x86_64 shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-11-30  7:13 ` [6/8, v6] NUMA Hotplug Emulator: Fake CPU socket with logical CPU on x86 shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-11-30  7:13 ` [7/8, v6] NUMA Hotplug Emulator: extend memory probe interface to support NUMA shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-12-02  0:55   ` David Rientjes
2010-12-02  0:55     ` David Rientjes
2010-11-30  7:13 ` [8/8, v6] NUMA Hotplug Emulator: implement debugfs interface for memory probe shaohui.zheng
2010-11-30  7:13   ` shaohui.zheng
2010-12-02  0:57   ` David Rientjes
2010-12-02  0:57     ` David Rientjes
2010-12-01 23:45     ` Shaohui Zheng [this message]
2010-12-01 23:45       ` Shaohui Zheng
2010-12-02  1:21       ` David Rientjes
2010-12-02  1:21         ` David Rientjes
     [not found] <A24AE1FFE7AEC5489F83450EE98351BF288D88D224@shsmsx502.ccr.corp.intel.com>
2010-12-02  0:27 ` Shaohui Zheng
2010-12-02  0:27   ` Shaohui Zheng
2010-12-02  2:13   ` David Rientjes
2010-12-02  2:13     ` David Rientjes
2010-12-02  2:35     ` Zheng, Shaohui
2010-12-02  2:35       ` Zheng, Shaohui
2010-12-02 23:34       ` David Rientjes
2010-12-02 23:34         ` David Rientjes
2010-12-06  1:22         ` Zheng, Shaohui
2010-12-06  1:22           ` Zheng, Shaohui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101201234514.GA13509@shaohui \
    --to=shaohui.zheng@intel.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=gregkh@suse.de \
    --cc=haicheng.li@intel.com \
    --cc=haicheng.li@linux.intel.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=shaohui.zheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.