All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock
Date: Thu, 2 Dec 2010 12:28:41 +1100	[thread overview]
Message-ID: <20101202012841.GL16922@dastard> (raw)
In-Reply-To: <20101130201734.GA16079@infradead.org>

On Tue, Nov 30, 2010 at 03:17:34PM -0500, Christoph Hellwig wrote:
> 
>  - xfs_efi_init needs to initialize efi_next_extent using ATOMIC_INIT

OK.

>  - there is a behaviour change about the xfs_trans_del_item call
>    in xfs_efi_item_unpin - before it was protected by the
>    XFS_EFI_CANCELED which was never set, and now it's not.

XFS_EFI_CANCELED has not been set in the code base since
xfs_efi_cancel() was removed back in 2006 by commit
065d312e15902976d256ddaf396a7950ec0350a8 ("[XFS] Remove unused
iop_abort log item operation), and even then xfs_efi_cancel() was
never called. I haven't tracked it back further than that (beyond
git history), but handling of efis in cancelled transactions has
been broken for a long time.

Basically, when we get an IOP_UNPIN(lip, 1); call from
xfs_trans_uncommit() (i.e. remove == 1), if we don't free the log
item descriptor we leak it. IOWs, the new behaviour introduced in
this patch is actually the correct behaviour.

>  - what happened to XFS_EFI_RECOVERED?  You changed it to be indexed
>    for the atomic bit-ops, but it's still used non-atomic in the log
>    recovery code.

Ah, I forgot to convert it.

>  - Why is XFS_EFI_COMMITTED cleared in xlog_recover_do_efi_trans,
>    where it can't ever be set?

It was just a straight transformation. I'll kill it.

>  - can you please add a shared helper for xfs_efi_item_unpin and
>    xfs_efi_release, ala:

Ok. Will do.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-12-02  1:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29  1:12 [PATCH 0/8] xfs: AIL lock contention reduction V2 Dave Chinner
2010-11-29  1:12 ` [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock Dave Chinner
2010-11-30 20:17   ` Christoph Hellwig
2010-12-02  1:28     ` Dave Chinner [this message]
2010-12-02 11:38       ` Christoph Hellwig
2010-12-03  5:24         ` Dave Chinner
2010-11-29  1:12 ` [PATCH 2/8] xfs: clean up xfs_ail_delete() Dave Chinner
2010-11-30 20:19   ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 3/8] xfs: bulk AIL insertion during transaction commit Dave Chinner
2010-11-30 22:40   ` Christoph Hellwig
2010-12-02  1:32     ` Dave Chinner
2010-11-29  1:12 ` [PATCH 4/8] xfs: reduce the number of AIL push wakeups Dave Chinner
2010-11-30 20:19   ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 5/8] xfs: consume iodone callback items on buffers as they are processed Dave Chinner
2010-11-30 20:24   ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 6/8] xfs: remove all the inodes on a buffer from the AIL in bulk Dave Chinner
2010-12-06 14:33   ` Christoph Hellwig
2010-12-07  3:44     ` Dave Chinner
2010-12-07  7:39       ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 8/8] xfs: use AIL bulk delete function to implement single delete Dave Chinner
2010-12-06 14:37   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101202012841.GL16922@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.