All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/8] xfs: remove all the inodes on a buffer from the AIL in bulk
Date: Mon, 6 Dec 2010 09:33:08 -0500	[thread overview]
Message-ID: <20101206143308.GA31100@infradead.org> (raw)
In-Reply-To: <1290993152-20999-7-git-send-email-david@fromorbit.com>

While the patch looks good for the ail lock contetion removal, I don't
quite like the model with the double iteration over the log item list
on the buffer.  What do you think about the following plan:

 (1) merge xfs_istale_done into xfs_iflush_done by checking for
     XFS_ISTALE
 (2) convert not only the inode log item completion to your new scheme,
     but also the dquots
 (3) replace xfs_buf_do_callbacks with a callback in the buffer, which
     now points to the inode and dqout routines, or calls the completion
     for the only items in "normal" buf items.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-12-06 14:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29  1:12 [PATCH 0/8] xfs: AIL lock contention reduction V2 Dave Chinner
2010-11-29  1:12 ` [PATCH 1/8] xfs: Pull EFI/EFD handling out from under the AIL lock Dave Chinner
2010-11-30 20:17   ` Christoph Hellwig
2010-12-02  1:28     ` Dave Chinner
2010-12-02 11:38       ` Christoph Hellwig
2010-12-03  5:24         ` Dave Chinner
2010-11-29  1:12 ` [PATCH 2/8] xfs: clean up xfs_ail_delete() Dave Chinner
2010-11-30 20:19   ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 3/8] xfs: bulk AIL insertion during transaction commit Dave Chinner
2010-11-30 22:40   ` Christoph Hellwig
2010-12-02  1:32     ` Dave Chinner
2010-11-29  1:12 ` [PATCH 4/8] xfs: reduce the number of AIL push wakeups Dave Chinner
2010-11-30 20:19   ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 5/8] xfs: consume iodone callback items on buffers as they are processed Dave Chinner
2010-11-30 20:24   ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 6/8] xfs: remove all the inodes on a buffer from the AIL in bulk Dave Chinner
2010-12-06 14:33   ` Christoph Hellwig [this message]
2010-12-07  3:44     ` Dave Chinner
2010-12-07  7:39       ` Christoph Hellwig
2010-11-29  1:12 ` [PATCH 8/8] xfs: use AIL bulk delete function to implement single delete Dave Chinner
2010-12-06 14:37   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101206143308.GA31100@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.