All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmci: supply per-instance regulator name
Date: Thu, 2 Dec 2010 12:06:08 +0000	[thread overview]
Message-ID: <20101202120608.GC3182@sirena.org.uk> (raw)
In-Reply-To: <20101202115700.GF29347@n2100.arm.linux.org.uk>

On Thu, Dec 02, 2010 at 11:57:00AM +0000, Russell King - ARM Linux wrote:

> It seems that the regulator code is making all the same mistakes that
> historically were made with the clk API code.

It's not...

> Rather than using the struct device, it's trying to use the regulator

...it does exactly this.  Passing names is not good practice.

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: supply per-instance regulator name
Date: Thu, 2 Dec 2010 12:06:08 +0000	[thread overview]
Message-ID: <20101202120608.GC3182@sirena.org.uk> (raw)
In-Reply-To: <20101202115700.GF29347@n2100.arm.linux.org.uk>

On Thu, Dec 02, 2010 at 11:57:00AM +0000, Russell King - ARM Linux wrote:

> It seems that the regulator code is making all the same mistakes that
> historically were made with the clk API code.

It's not...

> Rather than using the struct device, it's trying to use the regulator

...it does exactly this.  Passing names is not good practice.

  reply	other threads:[~2010-12-02 12:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 11:35 [PATCH] mmci: supply per-instance regulator name Linus Walleij
2010-12-02 11:35 ` Linus Walleij
2010-12-02 11:57 ` Russell King - ARM Linux
2010-12-02 11:57   ` Russell King - ARM Linux
2010-12-02 12:06   ` Mark Brown [this message]
2010-12-02 12:06     ` Mark Brown
2010-12-02 12:03 ` Mark Brown
2010-12-02 12:03   ` Mark Brown
2010-12-02 12:28   ` Russell King - ARM Linux
2010-12-02 12:28     ` Russell King - ARM Linux
2010-12-02 13:08     ` Mark Brown
2010-12-02 13:08       ` Mark Brown
2010-12-02 13:23       ` Linus Walleij
2010-12-02 13:23         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101202120608.GC3182@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.