From: Tony Lindgren <tony@atomide.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
Date: Sat, 4 Dec 2010 19:10:03 -0800 [thread overview]
Message-ID: <20101205031002.GP17222@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1012042126350.10437@xanadu.home>
* Nicolas Pitre <nico@fluxnic.net> [101204 18:26]:
> On Sat, 4 Dec 2010, Tony Lindgren wrote:
>
> My only problem with your approach is the global addition of
> asm_irq_base and asm_irq_flags in generic code which might not be useful
> and/or appropriate for all targets. If you were confining them to some
> OMAP specific file then I wouldn't mind as much. Looking at the patch I
> see that you had omap_irq_base before. Why wasn't that sufficient?
> Only omap_irq_flags would be missing.
I guess I was thinking this is something that might help others
to build more machines into one defconfig. If that's not the case,
sure these can be kept omap specific.
After a quick browsing of the entry-macro.S files, looks like
there's some similar ifdeffery for get_irqnr_* macros that just might
be possible to clear out with asm_irq_base and asm_irq_flags:
arch/arm/mach-davinci/include/mach/entry-macro.S
arch/arm/mach-s5p64x0/include/mach/entry-macro.S
arch/arm/mach-ixp4xx/include/mach/entry-macro.S
arch/arm/mach-h720x/include/mach/entry-macro.S
arch/arm/plat-mxc/include/mach/entry-macro.S
Maybe let's wait a while to see if there are other use cases,
if not, I'll make them omap specific.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier
Date: Sat, 4 Dec 2010 19:10:03 -0800 [thread overview]
Message-ID: <20101205031002.GP17222@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1012042126350.10437@xanadu.home>
* Nicolas Pitre <nico@fluxnic.net> [101204 18:26]:
> On Sat, 4 Dec 2010, Tony Lindgren wrote:
>
> My only problem with your approach is the global addition of
> asm_irq_base and asm_irq_flags in generic code which might not be useful
> and/or appropriate for all targets. If you were confining them to some
> OMAP specific file then I wouldn't mind as much. Looking at the patch I
> see that you had omap_irq_base before. Why wasn't that sufficient?
> Only omap_irq_flags would be missing.
I guess I was thinking this is something that might help others
to build more machines into one defconfig. If that's not the case,
sure these can be kept omap specific.
After a quick browsing of the entry-macro.S files, looks like
there's some similar ifdeffery for get_irqnr_* macros that just might
be possible to clear out with asm_irq_base and asm_irq_flags:
arch/arm/mach-davinci/include/mach/entry-macro.S
arch/arm/mach-s5p64x0/include/mach/entry-macro.S
arch/arm/mach-ixp4xx/include/mach/entry-macro.S
arch/arm/mach-h720x/include/mach/entry-macro.S
arch/arm/plat-mxc/include/mach/entry-macro.S
Maybe let's wait a while to see if there are other use cases,
if not, I'll make them omap specific.
Regards,
Tony
next prev parent reply other threads:[~2010-12-05 3:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 0:20 [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier Tony Lindgren
2010-12-04 0:20 ` Tony Lindgren
2010-12-04 0:20 ` [PATCH 1/4] ARM: Add asm_irq_base and asm_irq_flags for entry-armv.S macros Tony Lindgren
2010-12-04 0:20 ` Tony Lindgren
2010-12-04 0:20 ` [PATCH 2/4] omap2+: Use asm_irq_base for entry-macro.S Tony Lindgren
2010-12-04 0:20 ` Tony Lindgren
2010-12-04 0:20 ` [PATCH 3/4] omap1: Use asm_irq_flags " Tony Lindgren
2010-12-04 0:20 ` Tony Lindgren
2010-12-04 0:20 ` [PATCH 4/4] omap1: Use get_irqnr_preamble Tony Lindgren
2010-12-04 0:20 ` Tony Lindgren
2010-12-04 5:49 ` [PATCH 0/4] Patches to make multi-soc handling in entry-armv.S easier Nicolas Pitre
2010-12-04 5:49 ` Nicolas Pitre
2010-12-04 18:05 ` Tony Lindgren
2010-12-04 18:05 ` Tony Lindgren
2010-12-05 2:36 ` Nicolas Pitre
2010-12-05 2:36 ` Nicolas Pitre
2010-12-05 3:10 ` Tony Lindgren [this message]
2010-12-05 3:10 ` Tony Lindgren
2010-12-08 1:45 ` Tony Lindgren
2010-12-08 1:45 ` Tony Lindgren
2010-12-08 1:47 ` [PATCH 1/3] omap1: Use asm_irq_flags for entry-macro.S Tony Lindgren
2010-12-08 1:47 ` Tony Lindgren
2010-12-10 16:06 ` Janusz Krzysztofik
2010-12-10 16:06 ` Janusz Krzysztofik
2010-12-10 17:44 ` Tony Lindgren
2010-12-10 17:44 ` Tony Lindgren
2010-12-08 1:48 ` [PATCH 2/3] omap1: Use get_irqnr_preamble Tony Lindgren
2010-12-08 1:48 ` Tony Lindgren
2010-12-08 1:49 ` [PATCH 3/3] omap2+: Initialize omap_irq_base for entry-macro.S from platform code Tony Lindgren
2010-12-08 1:49 ` Tony Lindgren
2010-12-13 11:57 ` [PATCH 3/3] omap2+: Initialize omap_irq_base for entry-macro.Sfrom " Rajendra Nayak
2010-12-13 11:57 ` Rajendra Nayak
2010-12-15 3:25 ` Tony Lindgren
2010-12-15 3:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101205031002.GP17222@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.