From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Enable garbage collection of unused input sections.
Date: Sun, 05 Dec 2010 13:23:14 +0100 [thread overview]
Message-ID: <20101205122314.34EB0351@gemini.denx.de> (raw)
In-Reply-To: <1291545952-26761-2-git-send-email-luigi.mantellini@idf-hit.com>
Dear Luigi 'Comio' Mantellini,
In message <1291545952-26761-2-git-send-email-luigi.mantellini@idf-hit.com> you wrote:
> When available, enable the CC -ffunction-sections/-fdata-sections options and
> the LD --gc-sections in order to isolate and remove from final executable the
> unused functions.
...
> ---
> config.mk | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
Why do you ignore my previous review comments?
You cannot simply turn this feature on globally for all boards. You
will have to make appropriate adjustments more or less everywhere:
- some architectures already have these options set, so these should
be removed from the architecture / board specific config files
- other architectures have this NOT set, and they need adjustments to
the respective inker scripts.
As is, your patch breaks a zillion of boards.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To the systems programmer, users and applications serve only to
provide a test load.
next prev parent reply other threads:[~2010-12-05 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 10:45 [U-Boot] [PATCH] Enable garbage collection of unused input sections Luigi 'Comio' Mantellini
2010-12-05 10:45 ` Luigi 'Comio' Mantellini
2010-12-05 12:23 ` Wolfgang Denk [this message]
2010-12-05 12:33 ` Luigi Mantellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101205122314.34EB0351@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.