All of lore.kernel.org
 help / color / mirror / Atom feed
* sound: Fixed line limit issue in sound/ac97_bus.c
@ 2010-12-06 15:07 Jeffrin Jose
  2010-12-06 15:12   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Jeffrin Jose @ 2010-12-06 15:07 UTC (permalink / raw)
  To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel, linux-kernel, ahiliation

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

hello.
a small patch for a format issue is attached with this
mail.
-- 
software engineer.
department of computer science
rajagiri school of engineering and technology.

[-- Attachment #2: 0001-sound-Fixed-line-limit-issue-in-sound-ac97_bus.c.patch --]
[-- Type: text/x-diff, Size: 1105 bytes --]

>From a2c2867876c246420a199a0fb4c36ad2965a42cc Mon Sep 17 00:00:00 2001
From: Jeffrin Jose <ahiliation@yahoo.co.in>
Date: Mon, 6 Dec 2010 19:27:53 +0530
Subject: [PATCH] sound: Fixed line limit issue in sound/ac97_bus.c
 This is a patch to the sound/ac97_bus.c file that fixes up a 80 character
 line limit issue found by the checkpatch.pl tool.
 Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>

---
 sound/ac97_bus.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
index a351dd0..c93251a 100644
--- a/sound/ac97_bus.c
+++ b/sound/ac97_bus.c
@@ -19,9 +19,9 @@
 
 /*
  * Let drivers decide whether they want to support given codec from their
- * probe method.  Drivers have direct access to the struct snd_ac97 structure and may
- * decide based on the id field amongst other things.
- */
+ * probe method. Drivers have direct access to the struct snd_ac97
+ * structure and may  decide based on the id field amongst other things.
+*/
 static int ac97_bus_match(struct device *dev, struct device_driver *drv)
 {
 	return 1;
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: sound: Fixed line limit issue in sound/ac97_bus.c
  2010-12-06 15:07 sound: Fixed line limit issue in sound/ac97_bus.c Jeffrin Jose
@ 2010-12-06 15:12   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2010-12-06 15:12 UTC (permalink / raw)
  To: Jeffrin Jose; +Cc: alsa-devel, linux-kernel

At Mon, 6 Dec 2010 20:37:24 +0530,
Jeffrin Jose wrote:
> 
> hello.
> a small patch for a format issue is attached with this
> mail.

Thanks for the patch.

I applied it now, but had to fix a few things manually:
 - A blank line is necessary between the patch subject and the
   changelog text; otherwise git-am will be confused
 - You don't have to indent the change text
 - Align the closing comment "*/"


Takashi

> -- 
> software engineer.
> department of computer science
> rajagiri school of engineering and technology.
> [2 0001-sound-Fixed-line-limit-issue-in-sound-ac97_bus.c.patch <text/x-diff; us-ascii (7bit)>]
> >From a2c2867876c246420a199a0fb4c36ad2965a42cc Mon Sep 17 00:00:00 2001
> From: Jeffrin Jose <ahiliation@yahoo.co.in>
> Date: Mon, 6 Dec 2010 19:27:53 +0530
> Subject: [PATCH] sound: Fixed line limit issue in sound/ac97_bus.c
>  This is a patch to the sound/ac97_bus.c file that fixes up a 80 character
>  line limit issue found by the checkpatch.pl tool.
>  Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
> 
> ---
>  sound/ac97_bus.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
> index a351dd0..c93251a 100644
> --- a/sound/ac97_bus.c
> +++ b/sound/ac97_bus.c
> @@ -19,9 +19,9 @@
>  
>  /*
>   * Let drivers decide whether they want to support given codec from their
> - * probe method.  Drivers have direct access to the struct snd_ac97 structure and may
> - * decide based on the id field amongst other things.
> - */
> + * probe method. Drivers have direct access to the struct snd_ac97
> + * structure and may  decide based on the id field amongst other things.
> +*/
>  static int ac97_bus_match(struct device *dev, struct device_driver *drv)
>  {
>  	return 1;
> -- 
> 1.7.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: sound: Fixed line limit issue in sound/ac97_bus.c
@ 2010-12-06 15:12   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2010-12-06 15:12 UTC (permalink / raw)
  To: Jeffrin Jose; +Cc: Jaroslav Kysela, alsa-devel, linux-kernel

At Mon, 6 Dec 2010 20:37:24 +0530,
Jeffrin Jose wrote:
> 
> hello.
> a small patch for a format issue is attached with this
> mail.

Thanks for the patch.

I applied it now, but had to fix a few things manually:
 - A blank line is necessary between the patch subject and the
   changelog text; otherwise git-am will be confused
 - You don't have to indent the change text
 - Align the closing comment "*/"


Takashi

> -- 
> software engineer.
> department of computer science
> rajagiri school of engineering and technology.
> [2 0001-sound-Fixed-line-limit-issue-in-sound-ac97_bus.c.patch <text/x-diff; us-ascii (7bit)>]
> >From a2c2867876c246420a199a0fb4c36ad2965a42cc Mon Sep 17 00:00:00 2001
> From: Jeffrin Jose <ahiliation@yahoo.co.in>
> Date: Mon, 6 Dec 2010 19:27:53 +0530
> Subject: [PATCH] sound: Fixed line limit issue in sound/ac97_bus.c
>  This is a patch to the sound/ac97_bus.c file that fixes up a 80 character
>  line limit issue found by the checkpatch.pl tool.
>  Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
> 
> ---
>  sound/ac97_bus.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
> index a351dd0..c93251a 100644
> --- a/sound/ac97_bus.c
> +++ b/sound/ac97_bus.c
> @@ -19,9 +19,9 @@
>  
>  /*
>   * Let drivers decide whether they want to support given codec from their
> - * probe method.  Drivers have direct access to the struct snd_ac97 structure and may
> - * decide based on the id field amongst other things.
> - */
> + * probe method. Drivers have direct access to the struct snd_ac97
> + * structure and may  decide based on the id field amongst other things.
> +*/
>  static int ac97_bus_match(struct device *dev, struct device_driver *drv)
>  {
>  	return 1;
> -- 
> 1.7.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-06 15:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-06 15:07 sound: Fixed line limit issue in sound/ac97_bus.c Jeffrin Jose
2010-12-06 15:12 ` Takashi Iwai
2010-12-06 15:12   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.