All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: "R, Durgadoss" <durgadoss.r@intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [lm-sensors] Patch[1/2] Adding Core and Package Thermal Threshold Support to Coretemp
Date: Wed, 8 Dec 2010 09:11:38 -0800	[thread overview]
Message-ID: <20101208171138.GA28901@ericsson.com> (raw)
In-Reply-To: <20101208162214.353e3899@endymion.delvare>

On Wed, Dec 08, 2010 at 10:22:14AM -0500, Jean Delvare wrote:
> On Wed, 8 Dec 2010 14:40:29 +0530, R, Durgadoss wrote:
> > Hi Fenghua,
> > 
> > This patch adds the core and package thermal threshold support to coretemp.c.
> > These thresholds can be read/written using the hwmon sysfs interfaces
> > temp1_core_thresh[0/1] and temp1_pkg_thresh[0/1].
> 
> The package temperature isn't currently supported by the coretemp
> driver but by the pkgtemp driver. It makes no sense to add support for
> package thermal threshold to coretemp as long as the pkgtemp functionality
> hasn't been merged back into coretemp. This was the plan, BTW, I
> objected to the very existence of a separate pkgtemp driver since day
> 1, and I thought we had agreed that pkgtemp would be removed and its
> functionality would be merged into coretemp.
> 
Doesn't seem to be happening. Maybe we should reject further changes (other than
bug fixes) for those drivers until the cleanup has been done.

What is your take on the ABI changes ? For me, there are two questions: Do we need
new attributes ? If we do, what should be the attribute name(s) and semantics ?

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: "R, Durgadoss" <durgadoss.r@intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [lm-sensors] Patch[1/2] Adding Core and Package Thermal
Date: Wed, 08 Dec 2010 17:11:38 +0000	[thread overview]
Message-ID: <20101208171138.GA28901@ericsson.com> (raw)
In-Reply-To: <20101208162214.353e3899@endymion.delvare>

On Wed, Dec 08, 2010 at 10:22:14AM -0500, Jean Delvare wrote:
> On Wed, 8 Dec 2010 14:40:29 +0530, R, Durgadoss wrote:
> > Hi Fenghua,
> > 
> > This patch adds the core and package thermal threshold support to coretemp.c.
> > These thresholds can be read/written using the hwmon sysfs interfaces
> > temp1_core_thresh[0/1] and temp1_pkg_thresh[0/1].
> 
> The package temperature isn't currently supported by the coretemp
> driver but by the pkgtemp driver. It makes no sense to add support for
> package thermal threshold to coretemp as long as the pkgtemp functionality
> hasn't been merged back into coretemp. This was the plan, BTW, I
> objected to the very existence of a separate pkgtemp driver since day
> 1, and I thought we had agreed that pkgtemp would be removed and its
> functionality would be merged into coretemp.
> 
Doesn't seem to be happening. Maybe we should reject further changes (other than
bug fixes) for those drivers until the cleanup has been done.

What is your take on the ABI changes ? For me, there are two questions: Do we need
new attributes ? If we do, what should be the attribute name(s) and semantics ?

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2010-12-08 17:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08  9:10 Patch[1/2] Adding Core and Package Thermal Threshold Support to Coretemp R, Durgadoss
2010-12-08  9:22 ` [lm-sensors] Patch[1/2] Adding Core and Package Thermal Threshold R, Durgadoss
2010-12-08 14:49 ` [lm-sensors] Patch[1/2] Adding Core and Package Thermal Threshold Support to Coretemp Guenter Roeck
2010-12-08 14:49   ` [lm-sensors] Patch[1/2] Adding Core and Package Thermal Guenter Roeck
2010-12-08 15:22 ` [lm-sensors] Patch[1/2] Adding Core and Package Thermal Threshold Support to Coretemp Jean Delvare
2010-12-08 15:22   ` [lm-sensors] Patch[1/2] Adding Core and Package Thermal Jean Delvare
2010-12-08 16:36   ` [lm-sensors] Patch[1/2] Adding Core and Package Thermal Threshold Support to Coretemp R, Durgadoss
2010-12-08 16:48     ` [lm-sensors] Patch[1/2] Adding Core and Package Thermal R, Durgadoss
2010-12-08 17:11   ` Guenter Roeck [this message]
2010-12-08 17:11     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208171138.GA28901@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=durgadoss.r@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=khali@linux-fr.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.