From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: make existing convertion precedent over new lock
Date: Wed, 8 Dec 2010 10:07:57 -0800 [thread overview]
Message-ID: <20101208180757.GC21913@mail.oracle.com> (raw)
In-Reply-To: <201012081237.oB7Ibeoo012391@acsinet15.oracle.com>
On Wed, Dec 08, 2010 at 08:34:39PM +0800, Wengang Wang wrote:
> Make existing convertion precedent over new lock. It makes o2dlm locking more
> like fair locking.
Is this a problem you were solving, or just something you
thought about while reading the code? If it was a problem you ran
into, can you give the details?
Joel
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
> fs/ocfs2/dlm/dlmlock.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmlock.c b/fs/ocfs2/dlm/dlmlock.c
> index 69cf369..7009292 100644
> --- a/fs/ocfs2/dlm/dlmlock.c
> +++ b/fs/ocfs2/dlm/dlmlock.c
> @@ -106,6 +106,9 @@ static int dlm_can_grant_new_lock(struct dlm_lock_resource *res,
>
> if (!dlm_lock_compatible(tmplock->ml.type, lock->ml.type))
> return 0;
> + if (!dlm_lock_compatible(tmplock->ml.convert_type,
> + lock->ml.type))
> + return 0;
> }
>
> return 1;
> --
> 1.7.2.3
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Life's Little Instruction Book #207
"Swing for the fence."
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-12-08 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 12:34 [Ocfs2-devel] [PATCH] ocfs2/dlm: make existing convertion precedent over new lock Wengang Wang
2010-12-08 18:07 ` Joel Becker [this message]
2010-12-08 18:12 ` Joel Becker
2010-12-08 18:30 ` Sunil Mushran
2010-12-09 1:33 ` Wengang Wang
2010-12-16 8:52 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208180757.GC21913@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.