All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wengang Wang <wen.gang.wang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/dlm: make existing convertion precedent over new lock
Date: Thu, 9 Dec 2010 09:33:08 +0800	[thread overview]
Message-ID: <20101209013308.GA3090@laptop.jp.oracle.com> (raw)
In-Reply-To: <4CFFCEB8.8000202@oracle.com>

Hi Sunil/Joel,

On 10-12-08 10:30, Sunil Mushran wrote:
> On 12/08/2010 10:12 AM, Joel Becker wrote:
> >On Wed, Dec 08, 2010 at 10:07:57AM -0800, Joel Becker wrote:
> >>On Wed, Dec 08, 2010 at 08:34:39PM +0800, Wengang Wang wrote:
> >>>Make existing convertion precedent over new lock. It makes o2dlm locking more
> >>>like fair locking.
> >>	Is this a problem you were solving, or just something you
> >>thought about while reading the code?  If it was a problem you ran
> >>into, can you give the details?
> >	It looks like you're just emulating the logic from
> >__dlmconvert_master().  That makes sense.
> 
> This fix is an offshoot of the conversation in his thread.
> http://oss.oracle.com/pipermail/ocfs2-devel/2010-November/007524.html

Yes. The patch tries to fix that problem.
 
> The fix looks ok. But I would rather that we confirm this problem and the
> fix before we push it upstream.

Yes, understand. 
> Wengang, Have you attempted to reproduce the problem and/or test the fix?

I didn't let ct to test the patch yet. I can't reproduce it in house.
What I tested is very common test cases, such as parallel listing and
parallel kernel compiling.

I will let ct test with the patch. But since it's not a frequently
hit problem, not easy to say if the patch works....

What's the idea for such cases?

regards,
wengang.

  reply	other threads:[~2010-12-09  1:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 12:34 [Ocfs2-devel] [PATCH] ocfs2/dlm: make existing convertion precedent over new lock Wengang Wang
2010-12-08 18:07 ` Joel Becker
2010-12-08 18:12   ` Joel Becker
2010-12-08 18:30     ` Sunil Mushran
2010-12-09  1:33       ` Wengang Wang [this message]
2010-12-16  8:52 ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101209013308.GA3090@laptop.jp.oracle.com \
    --to=wen.gang.wang@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.