From: Dan Carpenter <error27@gmail.com>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/uverbs: Handle large number of entries in poll CQ
Date: Thu, 09 Dec 2010 06:04:42 +0000 [thread overview]
Message-ID: <20101209060442.GS10623@bicker> (raw)
In-Reply-To: <adaaakfkeee.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
On Wed, Dec 08, 2010 at 03:56:09PM -0800, Roland Dreier wrote:
> + tmp.port_num = wc->port_num;
> + tmp.reserved = wc->port_num;
I would probably have put a zero in tmp.reserved.
Otherwise it looks good.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/uverbs: Handle large number of entries in poll CQ
Date: Thu, 9 Dec 2010 09:04:42 +0300 [thread overview]
Message-ID: <20101209060442.GS10623@bicker> (raw)
In-Reply-To: <adaaakfkeee.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
On Wed, Dec 08, 2010 at 03:56:09PM -0800, Roland Dreier wrote:
> + tmp.port_num = wc->port_num;
> + tmp.reserved = wc->port_num;
I would probably have put a zero in tmp.reserved.
Otherwise it looks good.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-12-09 6:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 23:56 [PATCH] IB/uverbs: Handle large number of entries in poll CQ Roland Dreier
2010-12-08 23:56 ` Roland Dreier
[not found] ` <adaaakfkeee.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-12-09 6:04 ` Dan Carpenter [this message]
2010-12-09 6:04 ` Dan Carpenter
2010-12-09 7:32 ` Roland Dreier
2010-12-09 7:32 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209060442.GS10623@bicker \
--to=error27@gmail.com \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.