From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Vitaly Wool <vitalywool@gmail.com>,
linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] OMAP2+: PM/serial: fix console semaphore acquire during suspend
Date: Thu, 9 Dec 2010 16:57:17 -0800 [thread overview]
Message-ID: <20101210005717.GP3054@atomide.com> (raw)
In-Reply-To: <87zksfc53b.fsf@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [101209 07:40]:
> Vitaly Wool <vitalywool@gmail.com> writes:
> >>
> >> +static void omap2_pm_end(void)
> >> +{
> >> + suspend_state = PM_SUSPEND_ON;
> >> + return;
> >> +}
> >
> > Redundant return.
>
> but harmless
I'll queue this fix, will leave out the harmless return.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] OMAP2+: PM/serial: fix console semaphore acquire during suspend
Date: Thu, 9 Dec 2010 16:57:17 -0800 [thread overview]
Message-ID: <20101210005717.GP3054@atomide.com> (raw)
In-Reply-To: <87zksfc53b.fsf@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [101209 07:40]:
> Vitaly Wool <vitalywool@gmail.com> writes:
> >>
> >> +static void omap2_pm_end(void)
> >> +{
> >> + ? ? ? suspend_state = PM_SUSPEND_ON;
> >> + ? ? ? return;
> >> +}
> >
> > Redundant return.
>
> but harmless
I'll queue this fix, will leave out the harmless return.
Regards,
Tony
next prev parent reply other threads:[~2010-12-10 0:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 22:40 [PATCH v3] OMAP2+: PM/serial: fix console semaphore acquire during suspend Kevin Hilman
2010-12-08 22:40 ` Kevin Hilman
2010-12-08 23:51 ` Vitaly Wool
2010-12-08 23:51 ` Vitaly Wool
2010-12-09 15:56 ` Kevin Hilman
2010-12-09 15:56 ` Kevin Hilman
2010-12-10 0:57 ` Tony Lindgren [this message]
2010-12-10 0:57 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210005717.GP3054@atomide.com \
--to=tony@atomide.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.