From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Alexander <subaparts@yandex.ru>
Cc: alsa-devel@alsa-project.org, ryan@bluewatersys.com,
linux-arm-kernel@lists.infradead.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH 1/3] ASoC: EP93xx I2S and PCM fixes
Date: Fri, 10 Dec 2010 15:07:58 +0000 [thread overview]
Message-ID: <20101210150758.GE3200@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291929258.16839.17.camel@r60e>
On Fri, Dec 10, 2010 at 12:14:18AM +0300, Alexander wrote:
> BTW, it's how original Cirrus's sound driver had done it's work. Cirrus
> programmers had not found a way to overcome this. The datasheets for
> EP93xx series cover everything only briefly... The dumbness of EP93xx's
> DMA is also the reason why we do not have DMA in serial ports and SSP...
> The function I'm talking about is snd_ep93xx_dma2usr_ratio(), as told in
> comments "For audio playback, we convert samples of arbitrary format to
> be 32 bit for our hardware".
This doesn't really answer any of my technical questions about what's
going on here.
Please resubmit with a changelog explaining what the limitations are on
both sides (DMA seems clear but the I2S also needs to be covered) and
makes it clear why the functionality is being reduced like this. This
will ensure that users understand why the change has been made - right
now it looks like a serious functionality regression is being
introduced so we really should make it clear why this is being done.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ASoC: EP93xx I2S and PCM fixes
Date: Fri, 10 Dec 2010 15:07:58 +0000 [thread overview]
Message-ID: <20101210150758.GE3200@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1291929258.16839.17.camel@r60e>
On Fri, Dec 10, 2010 at 12:14:18AM +0300, Alexander wrote:
> BTW, it's how original Cirrus's sound driver had done it's work. Cirrus
> programmers had not found a way to overcome this. The datasheets for
> EP93xx series cover everything only briefly... The dumbness of EP93xx's
> DMA is also the reason why we do not have DMA in serial ports and SSP...
> The function I'm talking about is snd_ep93xx_dma2usr_ratio(), as told in
> comments "For audio playback, we convert samples of arbitrary format to
> be 32 bit for our hardware".
This doesn't really answer any of my technical questions about what's
going on here.
Please resubmit with a changelog explaining what the limitations are on
both sides (DMA seems clear but the I2S also needs to be covered) and
makes it clear why the functionality is being reduced like this. This
will ensure that users understand why the change has been made - right
now it looks like a serious functionality regression is being
introduced so we really should make it clear why this is being done.
next prev parent reply other threads:[~2010-12-10 15:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 12:01 [PATCH 1/3] ASoC: EP93xx I2S and PCM fixes Alexander
2010-12-08 12:01 ` Alexander
2010-12-08 12:46 ` Mark Brown
2010-12-08 12:46 ` Mark Brown
2010-12-09 0:37 ` Alexander
2010-12-09 0:37 ` Alexander
2010-12-09 10:54 ` Mark Brown
2010-12-09 10:54 ` Mark Brown
2010-12-09 12:17 ` Alexander
2010-12-09 12:17 ` Alexander
2010-12-09 12:34 ` Mark Brown
2010-12-09 12:34 ` Mark Brown
2010-12-09 21:14 ` Alexander
2010-12-09 21:14 ` Alexander
2010-12-10 15:07 ` Mark Brown [this message]
2010-12-10 15:07 ` Mark Brown
2011-01-16 11:21 ` Alexander
2011-01-16 11:21 ` Alexander
2011-01-16 11:27 ` Mark Brown
2011-01-16 11:27 ` Mark Brown
2010-12-09 0:43 ` [PATCH] ASoC: EP93xx: sampling rate range extended Alexander
2010-12-09 0:43 ` Alexander
2010-12-09 10:07 ` Liam Girdwood
2010-12-09 10:07 ` [alsa-devel] " Liam Girdwood
2010-12-09 11:10 ` Mark Brown
2010-12-09 11:10 ` Mark Brown
2010-12-09 0:59 ` [PATCH] ASoC: EP93xx: fixed LRCLK rate and DMA oper. in I2S code Alexander
2010-12-09 0:59 ` Alexander
2010-12-09 10:08 ` Liam Girdwood
2010-12-09 10:08 ` [alsa-devel] " Liam Girdwood
2011-01-16 12:48 ` Alexander
2011-01-16 12:48 ` Alexander
2011-01-17 14:05 ` Liam Girdwood
2011-01-17 14:05 ` [alsa-devel] " Liam Girdwood
2011-01-17 14:07 ` Mark Brown
2011-01-17 14:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210150758.GE3200@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=ryan@bluewatersys.com \
--cc=subaparts@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.