From: Evgeniy Polyakov <zbr@ioremap.net>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
virtualization@lists.osdl.org, Jesper Juhl <jj@chaosbits.net>,
devel@linuxdriverproject.org,
Ky Srinivasan <ksrinivasan@novell.com>
Subject: Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize
Date: Tue, 14 Dec 2010 01:03:33 +0300 [thread overview]
Message-ID: <20101213220333.GA1636@ioremap.net> (raw)
In-Reply-To: <1292274861-29673-1-git-send-email-hjanssen@microsoft.com>
On Mon, Dec 13, 2010 at 01:14:21PM -0800, Hank Janssen (hjanssen@microsoft.com) wrote:
> +static u8 *shut_txf_buf;
> +static u8 *time_txf_buf;
> +static u8 *hbeat_txf_buf;
Those are accessed without any kind of synchronization. I do not know
exact context, but are you sure it is single-threaded?
--
Evgeniy Polyakov
WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Jesper Juhl <jj@chaosbits.net>,
Ky Srinivasan <ksrinivasan@novell.com>
Subject: Re: [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize
Date: Tue, 14 Dec 2010 01:03:33 +0300 [thread overview]
Message-ID: <20101213220333.GA1636@ioremap.net> (raw)
In-Reply-To: <1292274861-29673-1-git-send-email-hjanssen@microsoft.com>
On Mon, Dec 13, 2010 at 01:14:21PM -0800, Hank Janssen (hjanssen@microsoft.com) wrote:
> +static u8 *shut_txf_buf;
> +static u8 *time_txf_buf;
> +static u8 *hbeat_txf_buf;
Those are accessed without any kind of synchronization. I do not know
exact context, but are you sure it is single-threaded?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2010-12-13 22:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 21:14 [PATCH 1/1] hv: Use only one txf buffer per channel and kmalloc on initialize Hank Janssen
2010-12-13 21:22 ` Jesper Juhl
2010-12-13 21:31 ` Hank Janssen
2010-12-13 21:47 ` Greg KH
2010-12-13 22:03 ` Evgeniy Polyakov [this message]
2010-12-13 22:03 ` Evgeniy Polyakov
2010-12-13 22:57 ` Hank Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213220333.GA1636@ioremap.net \
--to=zbr@ioremap.net \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=jj@chaosbits.net \
--cc=ksrinivasan@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.