From: "G, Manjunath Kondaiah" <manjugk@ti.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, tony@atomide.com,
linux-arm-kernel@lists.infradead.org,
Benoit Cousson <b-cousson@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH v1 3/9] OMAP2420: hwmod data: add system DMA]
Date: Wed, 15 Dec 2010 17:45:58 +0530 [thread overview]
Message-ID: <20101215121558.GE11931@GLPP-machine> (raw)
In-Reply-To: <20101215110917.GD11931@GLPP-machine>
On Wed, Dec 15, 2010 at 04:39:17PM +0530, G, Manjunath Kondaiah wrote:
> On Tue, Dec 14, 2010 at 07:25:23PM -0700, Paul Walmsley wrote:
> > Manju
> >
> > On Sat, 4 Dec 2010, G, Manjunath Kondaiah wrote:
> >
> > > Add OMAP2420 DMA hwmod data and also add required
> > > DMA device attributes.
> > >
> > > Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> > > Cc: Benoit Cousson <b-cousson@ti.com>
> > > Cc: Kevin Hilman <khilman@deeprootsystems.com>
> > > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > >
> > > +/* dma_system -> L3 */
> > > +static struct omap_hwmod_ocp_if omap2420_dma_system__l3 = {
> > > + .master = &omap2420_dma_system_hwmod,
> > > + .slave = &omap2420_l3_main_hwmod,
> > > + .clk = "l3_div_ck",
> >
> > This clock does not exist on OMAP2420. Did you test this patch on 2420?
>
> ok. will be replaced with "sdma_ick". I don't have 2420 for testing. I
> tested it on 2430. My understanding is that, DMA clock interface is same
> for 2420 and 2430. Correct me if am wrong.
Looking into omap3/omap4 structures, this entry takes core l3 clock.
This should be "sdma_fck" since it's parent is core_l3_ck.
Pls confirm.
-Manjunath
WARNING: multiple messages have this Message-ID (diff)
From: manjugk@ti.com (G, Manjunath Kondaiah)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 3/9] OMAP2420: hwmod data: add system DMA]
Date: Wed, 15 Dec 2010 17:45:58 +0530 [thread overview]
Message-ID: <20101215121558.GE11931@GLPP-machine> (raw)
In-Reply-To: <20101215110917.GD11931@GLPP-machine>
On Wed, Dec 15, 2010 at 04:39:17PM +0530, G, Manjunath Kondaiah wrote:
> On Tue, Dec 14, 2010 at 07:25:23PM -0700, Paul Walmsley wrote:
> > Manju
> >
> > On Sat, 4 Dec 2010, G, Manjunath Kondaiah wrote:
> >
> > > Add OMAP2420 DMA hwmod data and also add required
> > > DMA device attributes.
> > >
> > > Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> > > Cc: Benoit Cousson <b-cousson@ti.com>
> > > Cc: Kevin Hilman <khilman@deeprootsystems.com>
> > > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > >
> > > +/* dma_system -> L3 */
> > > +static struct omap_hwmod_ocp_if omap2420_dma_system__l3 = {
> > > + .master = &omap2420_dma_system_hwmod,
> > > + .slave = &omap2420_l3_main_hwmod,
> > > + .clk = "l3_div_ck",
> >
> > This clock does not exist on OMAP2420. Did you test this patch on 2420?
>
> ok. will be replaced with "sdma_ick". I don't have 2420 for testing. I
> tested it on 2430. My understanding is that, DMA clock interface is same
> for 2420 and 2430. Correct me if am wrong.
Looking into omap3/omap4 structures, this entry takes core l3 clock.
This should be "sdma_fck" since it's parent is core_l3_ck.
Pls confirm.
-Manjunath
next prev parent reply other threads:[~2010-12-15 12:14 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 3:43 [PATCH v1 0/9] OMAP: DMA: hwmod and DMA as platform device G, Manjunath Kondaiah
2010-12-04 3:43 ` [PATCH v1 1/9] OMAP: DMA: Replace read/write macros with functions G, Manjunath Kondaiah
2010-12-04 3:43 ` [PATCH v1 2/9] OMAP: DMA: Introduce errata handling feature G, Manjunath Kondaiah
2010-12-04 3:44 ` [PATCH v1 3/9] OMAP2420: hwmod data: add system DMA G, Manjunath Kondaiah
2010-12-15 2:25 ` Paul Walmsley
2010-12-15 2:25 ` Paul Walmsley
2010-12-15 11:09 ` G, Manjunath Kondaiah
2010-12-15 11:09 ` G, Manjunath Kondaiah
2010-12-15 12:15 ` G, Manjunath Kondaiah [this message]
2010-12-15 12:15 ` [PATCH v1 3/9] OMAP2420: hwmod data: add system DMA] G, Manjunath Kondaiah
2010-12-15 15:39 ` Paul Walmsley
2010-12-15 15:39 ` Paul Walmsley
2010-12-04 3:44 ` [PATCH v1 4/9] OMAP2430: hwmod data: add system DMA G, Manjunath Kondaiah
2010-12-15 2:27 ` Paul Walmsley
2010-12-15 2:27 ` Paul Walmsley
2010-12-15 10:59 ` G, Manjunath Kondaiah
2010-12-15 10:59 ` G, Manjunath Kondaiah
2010-12-15 15:14 ` Paul Walmsley
2010-12-15 15:14 ` Paul Walmsley
2010-12-15 15:53 ` G, Manjunath Kondaiah
2010-12-15 15:53 ` G, Manjunath Kondaiah
2010-12-04 3:44 ` [PATCH v1 5/9] OMAP3: " G, Manjunath Kondaiah
2010-12-04 3:44 ` [PATCH v1 6/9] OMAP4: " G, Manjunath Kondaiah
2010-12-04 3:44 ` [PATCH v1 7/9] OMAP1: DMA: Implement in platform device model G, Manjunath Kondaiah
2010-12-15 0:40 ` Kevin Hilman
2010-12-15 0:40 ` Kevin Hilman
2010-12-15 0:55 ` Kevin Hilman
2010-12-15 0:55 ` Kevin Hilman
2010-12-15 1:04 ` Tony Lindgren
2010-12-15 1:04 ` Tony Lindgren
2010-12-15 2:01 ` G, Manjunath Kondaiah
2010-12-15 2:01 ` G, Manjunath Kondaiah
2010-12-15 2:44 ` Tony Lindgren
2010-12-15 2:44 ` Tony Lindgren
2010-12-04 3:44 ` [PATCH v1 8/9] OMAP2+: DMA: hwmod: Device registration G, Manjunath Kondaiah
2010-12-04 3:44 ` [PATCH v1 9/9] OMAP: DMA: Convert DMA library into platform driver G, Manjunath Kondaiah
2010-12-07 11:04 ` [PATCH v1 0/9] OMAP: DMA: hwmod and DMA as platform device G, Manjunath Kondaiah
2010-12-07 11:04 ` G, Manjunath Kondaiah
2010-12-14 23:19 ` Tony Lindgren
2010-12-14 23:19 ` Tony Lindgren
2010-12-15 0:18 ` Kevin Hilman
2010-12-15 0:18 ` Kevin Hilman
2010-12-15 1:37 ` Kevin Hilman
2010-12-15 1:37 ` Kevin Hilman
2010-12-15 1:55 ` Tony Lindgren
2010-12-15 1:55 ` Tony Lindgren
2010-12-15 2:02 ` Kevin Hilman
2010-12-15 2:02 ` Kevin Hilman
2010-12-15 2:08 ` Tony Lindgren
2010-12-15 2:08 ` Tony Lindgren
2010-12-15 1:59 ` G, Manjunath Kondaiah
2010-12-15 1:59 ` G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215121558.GE11931@GLPP-machine \
--to=manjugk@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.