All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][TOOLS] libxc: finish discard_file_cache() for NetBSD
@ 2010-12-15 11:35 Christoph Egger
  2010-12-16 18:22 ` Ian Jackson
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Egger @ 2010-12-15 11:35 UTC (permalink / raw)
  To: xen-devel

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]


Hi,

attached patch completes discard_file_cache() for NetBSD.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_libxc.diff --]
[-- Type: text/x-diff, Size: 1130 bytes --]

diff -r be72873a6f30 tools/libxc/xc_netbsd.c
--- a/tools/libxc/xc_netbsd.c	Wed Dec 15 11:49:51 2010 +0100
+++ b/tools/libxc/xc_netbsd.c	Wed Dec 15 12:08:47 2010 +0100
@@ -280,11 +280,36 @@ int xc_evtchn_unmask(int xce_handle, evt
 /* Optionally flush file to disk and discard page cache */
 void discard_file_cache(xc_interface *xch, int fd, int flush) 
 {
+    off_t cur = 0;
+    int saved_errno = errno;
 
     if ( flush && (fsync(fd) < 0) )
     {
         /*PERROR("Failed to flush file: %s", strerror(errno));*/
+        goto out;
     }
+
+    /*
+     * Calculate last page boundry of amount written so far
+     * unless we are flushing in which case entire cache
+     * is discarded.
+     */
+    if ( !flush )
+    {
+        if ( ( cur = lseek(fd, 0, SEEK_CUR)) == (off_t)-1 )
+            cur = 0;
+        cur &= ~(PAGE_SIZE - 1);
+    }
+
+    /* Discard from the buffer cache. */
+    if ( posix_fadvise(fd, 0, cur, POSIX_FADV_DONTNEED) < 0 )
+    {
+        /*PERROR("Failed to discard cache: %s", strerror(errno));*/
+        goto out;
+    }
+
+ out:
+    errno = saved_errno;
 }
 
 int xc_gnttab_open(void)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][TOOLS] libxc: finish discard_file_cache() for NetBSD
  2010-12-15 11:35 [PATCH][TOOLS] libxc: finish discard_file_cache() for NetBSD Christoph Egger
@ 2010-12-16 18:22 ` Ian Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2010-12-16 18:22 UTC (permalink / raw)
  To: Christoph Egger; +Cc: xen-devel

Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] libxc: finish discard_file_cache() for NetBSD"):
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Applied, thanks.

Ian.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-16 18:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-15 11:35 [PATCH][TOOLS] libxc: finish discard_file_cache() for NetBSD Christoph Egger
2010-12-16 18:22 ` Ian Jackson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.