From: David Brown <davidb@codeaurora.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "Jeff Ohlstein" <johlstei@codeaurora.org>,
"David Brown" <davidb@codeaurora.org>,
"Daniel Walker" <dwalker@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Brian Swetland" <swetland@google.com>,
"Dima Zavin" <dima@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Bryan Huntsman" <bryanh@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Steve Muckle" <smuckle@codeaurora.org>
Subject: Re: [PATCH v5 5/5] msm: add SMP support for msm
Date: Wed, 15 Dec 2010 05:44:14 -0800 [thread overview]
Message-ID: <20101215134414.GA8682@huya.qualcomm.com> (raw)
In-Reply-To: <AANLkTimnuTcv+5cWNzvV-Z=1LHsAmTojDSBJMjjOs7K+@mail.gmail.com>
On Wed, Dec 15, 2010 at 12:35:18PM +0000, Catalin Marinas wrote:
> On 14 December 2010 04:50, Jeff Ohlstein <johlstei@codeaurora.org> wrote:
> > + outer_clean_range(__pa(&pen_release), __pa(&pen_release + 1));
> > + __asm__("sev");
> > + dsb();
>
> What's the need for the dsb() here (one before SEV maybe)?
>
> Also, do we need to add a "memory" clobber to the SEV asm, not sure
> whether the compiler would try to reorder the code.
It doesn't seem to, but it seems to me that it would be allowed to,
so, I would think the "memory" clobber should be there.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/5] msm: add SMP support for msm
Date: Wed, 15 Dec 2010 05:44:14 -0800 [thread overview]
Message-ID: <20101215134414.GA8682@huya.qualcomm.com> (raw)
In-Reply-To: <AANLkTimnuTcv+5cWNzvV-Z=1LHsAmTojDSBJMjjOs7K+@mail.gmail.com>
On Wed, Dec 15, 2010 at 12:35:18PM +0000, Catalin Marinas wrote:
> On 14 December 2010 04:50, Jeff Ohlstein <johlstei@codeaurora.org> wrote:
> > + ? ? ? outer_clean_range(__pa(&pen_release), __pa(&pen_release + 1));
> > + ? ? ? __asm__("sev");
> > + ? ? ? dsb();
>
> What's the need for the dsb() here (one before SEV maybe)?
>
> Also, do we need to add a "memory" clobber to the SEV asm, not sure
> whether the compiler would try to reorder the code.
It doesn't seem to, but it seems to me that it would be allowed to,
so, I would think the "memory" clobber should be there.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-15 13:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 4:50 [PATCH v4 0/5] SMP support for msm Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` [PATCH v4 1/5] msm: Secure Channel Manager (SCM) support Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` [PATCH v4 2/5] msm: scm-boot: Support for setting cold/warm boot addresses Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` [PATCH v4 3/5] msm: timer: SMP timer support for msm Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` [PATCH v4 4/5] msm: hotplug: support cpu hotplug on msm Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 17:30 ` Russell King - ARM Linux
2010-12-14 17:30 ` Russell King - ARM Linux
2010-12-14 22:31 ` Jeff Ohlstein
2010-12-14 22:31 ` Jeff Ohlstein
2010-12-14 22:31 ` Jeff Ohlstein
2010-12-14 4:50 ` [PATCH v5 5/5] msm: add SMP support for msm Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-14 4:50 ` Jeff Ohlstein
2010-12-15 12:35 ` Catalin Marinas
2010-12-15 12:35 ` Catalin Marinas
2010-12-15 13:44 ` David Brown [this message]
2010-12-15 13:44 ` David Brown
2010-12-15 16:03 ` Russell King - ARM Linux
2010-12-15 16:03 ` Russell King - ARM Linux
2010-12-15 17:42 ` Steve Muckle
2010-12-15 17:42 ` Steve Muckle
2010-12-14 16:59 ` [PATCH v4 0/5] " David Brown
2010-12-14 16:59 ` David Brown
-- strict thread matches above, loose matches on Subject: below --
2010-12-16 6:54 [PATCH v5 " Jeff Ohlstein
2010-12-16 6:54 ` [PATCH v5 5/5] msm: add " Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 6:54 ` Jeff Ohlstein
2010-12-16 21:44 ` Russell King - ARM Linux
2010-12-16 21:44 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215134414.GA8682@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=arve@android.com \
--cc=bryanh@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=dima@android.com \
--cc=dwalker@codeaurora.org \
--cc=johlstei@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=smuckle@codeaurora.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.