From: Bruce Cran <bruce@cran.org.uk>
To: Jens Axboe <JAxboe@fusionio.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [patch] Use C99 standard integer types
Date: Wed, 15 Dec 2010 09:37:54 -0700 [thread overview]
Message-ID: <20101215163754.00000c0e@unknown> (raw)
In-Reply-To: <4D08DED3.6000202@fusionio.com>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Wed, 15 Dec 2010 16:29:23 +0100
Jens Axboe <jaxboe@fusionio.com> wrote:
> Really blktrace_api.h should just go away, since it's an OS interface
> and should be exposed as such. We've traditionally always used __uxx
> types in those interfaces. You should not be picking that up on
> FreeBSD :-)
It looks like blktrace_api.h is being parsed through the depend rule
in Makefile.[FreeBSD|NetBSD|mac] due to the headers being listed in
$(SOURCE) - gcc just ignores missing <> headers while clang generates an
error as it builds the dependency list. Since headers which are
included within source files will be listed as a dependency anyway, I
think they can be removed from $(SOURCE).
--
Bruce Cran
[-- Attachment #2: Makefile.diff --]
[-- Type: application/octet-stream, Size: 1931 bytes --]
diff --git a/Makefile.FreeBSD b/Makefile.FreeBSD
index 9378b19..02ff95d 100644
--- a/Makefile.FreeBSD
+++ b/Makefile.FreeBSD
@@ -33,9 +33,7 @@ OBJS += engines/net.o
SOURCE = eta.c filehash.c filesetup.c fio.c gettime.c init.c ioengines.c \
io_u.c log.c memory.c mutex.c options.c parse.c rbtree.c smalloc.c \
stat.c parse.c crc/*.c engines/cpu.c engines/mmap.c \
- engines/posixaio.c engines/sync.c engines/null.c engines/net.c \
- *.h arch/*.h compiler/*.h crc/*.h lib/*.h \
- os/indirect.h os/kcompat.h os/os-freebsd.h os/os.h os/syslet.h
+ engines/posixaio.c engines/sync.c engines/null.c engines/net.c
ifneq ($(findstring $(MAKEFLAGS),s),s)
ifndef V
diff --git a/Makefile.NetBSD b/Makefile.NetBSD
index 9378b19..02ff95d 100644
--- a/Makefile.NetBSD
+++ b/Makefile.NetBSD
@@ -33,9 +33,7 @@ OBJS += engines/net.o
SOURCE = eta.c filehash.c filesetup.c fio.c gettime.c init.c ioengines.c \
io_u.c log.c memory.c mutex.c options.c parse.c rbtree.c smalloc.c \
stat.c parse.c crc/*.c engines/cpu.c engines/mmap.c \
- engines/posixaio.c engines/sync.c engines/null.c engines/net.c \
- *.h arch/*.h compiler/*.h crc/*.h lib/*.h \
- os/indirect.h os/kcompat.h os/os-freebsd.h os/os.h os/syslet.h
+ engines/posixaio.c engines/sync.c engines/null.c engines/net.c
ifneq ($(findstring $(MAKEFLAGS),s),s)
ifndef V
diff --git a/Makefile.mac b/Makefile.mac
index 25c7fde..3eb20be 100644
--- a/Makefile.mac
+++ b/Makefile.mac
@@ -33,8 +33,7 @@ OBJS += engines/net.o
SOURCE = eta.c filehash.c filesetup.c fio.c gettime.c init.c ioengines.c \
io_u.c log.c memory.c mutex.c options.c parse.c rbtree.c smalloc.c \
stat.c parse.c crc/*.c engines/cpu.c engines/mmap.c \
- engines/posixaio.c engines/sync.c engines/null.c engines/net.c \
- *.h */*.h
+ engines/posixaio.c engines/sync.c engines/null.c engines/net.c
ifneq ($(findstring $(MAKEFLAGS),s),s)
ifndef V
next prev parent reply other threads:[~2010-12-15 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:09 [patch] Use C99 standard integer types Bruce Cran
2010-12-15 15:29 ` Jens Axboe
2010-12-15 16:37 ` Bruce Cran [this message]
2010-12-15 18:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215163754.00000c0e@unknown \
--to=bruce@cran.org.uk \
--cc=JAxboe@fusionio.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.