From: Jens Axboe <jaxboe@fusionio.com>
To: Bruce Cran <bruce@cran.org.uk>
Cc: fio@vger.kernel.org
Subject: Re: [patch] Use C99 standard integer types
Date: Wed, 15 Dec 2010 19:30:20 +0100 [thread overview]
Message-ID: <4D09093C.1040504@fusionio.com> (raw)
In-Reply-To: <20101215163754.00000c0e@unknown>
On 2010-12-15 17:37, Bruce Cran wrote:
> On Wed, 15 Dec 2010 16:29:23 +0100
> Jens Axboe <jaxboe@fusionio.com> wrote:
>
>> Really blktrace_api.h should just go away, since it's an OS interface
>> and should be exposed as such. We've traditionally always used __uxx
>> types in those interfaces. You should not be picking that up on
>> FreeBSD :-)
>
> It looks like blktrace_api.h is being parsed through the depend rule
> in Makefile.[FreeBSD|NetBSD|mac] due to the headers being listed in
> $(SOURCE) - gcc just ignores missing <> headers while clang generates an
> error as it builds the dependency list. Since headers which are
> included within source files will be listed as a dependency anyway, I
> think they can be removed from $(SOURCE).
This looks good, thanks!
--
Jens Axboe
prev parent reply other threads:[~2010-12-15 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:09 [patch] Use C99 standard integer types Bruce Cran
2010-12-15 15:29 ` Jens Axboe
2010-12-15 16:37 ` Bruce Cran
2010-12-15 18:30 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D09093C.1040504@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=bruce@cran.org.uk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.