* [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages
@ 2010-12-08 13:00 Andreas Oberritter
2010-12-13 12:42 ` Andreas Oberritter
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Oberritter @ 2010-12-08 13:00 UTC (permalink / raw)
To: openembedded-devel
Introduce run_strip_funcs() to call the functions in
PACKAGESTRIPFUNCS and place it before populate_packages().
This allows users of do_split_packages() to package the .debug
directories, which get created by do_runstrip().
do_split_packages() is usually prepended to populate_packages().
Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
classes/package.bbclass | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/classes/package.bbclass b/classes/package.bbclass
index 2769595..678ffa9 100644
--- a/classes/package.bbclass
+++ b/classes/package.bbclass
@@ -367,6 +367,12 @@ python perform_packagecopy () {
os.system('cp -pPR %s/. %s/' % (installdest, pkgcopy))
}
+python run_strip_funcs() {
+ if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
+ for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
+ bb.build.exec_func(f, d)
+}
+
python populate_packages () {
import glob, errno, re,os
@@ -391,11 +397,6 @@ python populate_packages () {
else:
package_list.append(pkg)
-
- if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
- for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
- bb.build.exec_func(f, d)
-
pkgdest = bb.data.getVar('PKGDEST', d, True)
os.system('rm -rf %s' % pkgdest)
@@ -1011,6 +1012,7 @@ PACKAGE_PREPROCESS_FUNCS ?= ""
PACKAGEFUNCS ?= "perform_packagecopy \
${PACKAGE_PREPROCESS_FUNCS} \
package_do_split_locales \
+ run_strip_funcs \
populate_packages \
package_do_shlibs \
package_do_pkgconfig \
--
1.7.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages
2010-12-08 13:00 [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages Andreas Oberritter
@ 2010-12-13 12:42 ` Andreas Oberritter
2010-12-16 5:27 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Oberritter @ 2010-12-13 12:42 UTC (permalink / raw)
To: openembedded-devel
Ping
On 12/08/2010 02:00 PM, Andreas Oberritter wrote:
> Introduce run_strip_funcs() to call the functions in
> PACKAGESTRIPFUNCS and place it before populate_packages().
>
> This allows users of do_split_packages() to package the .debug
> directories, which get created by do_runstrip().
>
> do_split_packages() is usually prepended to populate_packages().
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
> ---
> classes/package.bbclass | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/classes/package.bbclass b/classes/package.bbclass
> index 2769595..678ffa9 100644
> --- a/classes/package.bbclass
> +++ b/classes/package.bbclass
> @@ -367,6 +367,12 @@ python perform_packagecopy () {
> os.system('cp -pPR %s/. %s/' % (installdest, pkgcopy))
> }
>
> +python run_strip_funcs() {
> + if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
> + for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
> + bb.build.exec_func(f, d)
> +}
> +
> python populate_packages () {
> import glob, errno, re,os
>
> @@ -391,11 +397,6 @@ python populate_packages () {
> else:
> package_list.append(pkg)
>
> -
> - if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
> - for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
> - bb.build.exec_func(f, d)
> -
> pkgdest = bb.data.getVar('PKGDEST', d, True)
> os.system('rm -rf %s' % pkgdest)
>
> @@ -1011,6 +1012,7 @@ PACKAGE_PREPROCESS_FUNCS ?= ""
> PACKAGEFUNCS ?= "perform_packagecopy \
> ${PACKAGE_PREPROCESS_FUNCS} \
> package_do_split_locales \
> + run_strip_funcs \
> populate_packages \
> package_do_shlibs \
> package_do_pkgconfig \
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages
2010-12-13 12:42 ` Andreas Oberritter
@ 2010-12-16 5:27 ` Khem Raj
2010-12-16 12:04 ` Andreas Oberritter
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2010-12-16 5:27 UTC (permalink / raw)
To: openembedded-devel
On (13/12/10 13:42), Andreas Oberritter wrote:
> Ping
>
> On 12/08/2010 02:00 PM, Andreas Oberritter wrote:
> > Introduce run_strip_funcs() to call the functions in
> > PACKAGESTRIPFUNCS and place it before populate_packages().
> >
> > This allows users of do_split_packages() to package the .debug
> > directories, which get created by do_runstrip().
> >
> > do_split_packages() is usually prepended to populate_packages().
> >
> > Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
looks ok to me. I thought .debug are automatically picked into -debug
packages
In what cases will this help ?
> > ---
> > classes/package.bbclass | 12 +++++++-----
> > 1 files changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/classes/package.bbclass b/classes/package.bbclass
> > index 2769595..678ffa9 100644
> > --- a/classes/package.bbclass
> > +++ b/classes/package.bbclass
> > @@ -367,6 +367,12 @@ python perform_packagecopy () {
> > os.system('cp -pPR %s/. %s/' % (installdest, pkgcopy))
> > }
> >
> > +python run_strip_funcs() {
> > + if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
> > + for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
> > + bb.build.exec_func(f, d)
> > +}
> > +
> > python populate_packages () {
> > import glob, errno, re,os
> >
> > @@ -391,11 +397,6 @@ python populate_packages () {
> > else:
> > package_list.append(pkg)
> >
> > -
> > - if (bb.data.getVar('PACKAGE_STRIP', d, True) != 'no'):
> > - for f in (bb.data.getVar('PACKAGESTRIPFUNCS', d, True) or '').split():
> > - bb.build.exec_func(f, d)
> > -
> > pkgdest = bb.data.getVar('PKGDEST', d, True)
> > os.system('rm -rf %s' % pkgdest)
> >
> > @@ -1011,6 +1012,7 @@ PACKAGE_PREPROCESS_FUNCS ?= ""
> > PACKAGEFUNCS ?= "perform_packagecopy \
> > ${PACKAGE_PREPROCESS_FUNCS} \
> > package_do_split_locales \
> > + run_strip_funcs \
> > populate_packages \
> > package_do_shlibs \
> > package_do_pkgconfig \
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages
2010-12-16 5:27 ` Khem Raj
@ 2010-12-16 12:04 ` Andreas Oberritter
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Oberritter @ 2010-12-16 12:04 UTC (permalink / raw)
To: openembedded-devel
On 12/16/2010 06:27 AM, Khem Raj wrote:
> On (13/12/10 13:42), Andreas Oberritter wrote:
>> Ping
>>
>> On 12/08/2010 02:00 PM, Andreas Oberritter wrote:
>>> Introduce run_strip_funcs() to call the functions in
>>> PACKAGESTRIPFUNCS and place it before populate_packages().
>>>
>>> This allows users of do_split_packages() to package the .debug
>>> directories, which get created by do_runstrip().
>>>
>>> do_split_packages() is usually prepended to populate_packages().
>>>
>>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
>
> looks ok to me. I thought .debug are automatically picked into -debug
> packages
> In what cases will this help ?
We have a set of plugins split into one package each. With this patch, I
can create "plugin-foo-dbg" packages, which seems to be much nicer than
having one meta-dbg package containing all debug symbols, especially
with a large amount of plugins.
Regards,
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-16 12:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-08 13:00 [PATCH resend] package.bbclass: call PACKAGESTRIPFUNCS before populate_packages Andreas Oberritter
2010-12-13 12:42 ` Andreas Oberritter
2010-12-16 5:27 ` Khem Raj
2010-12-16 12:04 ` Andreas Oberritter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.