* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. [not found] <E1PR45K-0000jK-SU@melo.openembedded.org> @ 2010-12-14 12:06 ` Dr. Michael Lauer 2010-12-14 13:30 ` Philip Balister 0 siblings, 1 reply; 8+ messages in thread From: Dr. Michael Lauer @ 2010-12-14 12:06 UTC (permalink / raw) To: openembedded-devel Am 10.12.2010 um 15:36 schrieb git version control: > Module: openembedded.git > Branch: org.openembedded.dev > Commit: 48e6a063370a38a35f31a28efd8f6ce6ebf00840 > URL: http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=48e6a063370a38a35f31a28efd8f6ce6ebf00840 > > Author: Philip Balister <philip@balister.org> > Date: Fri Dec 10 09:31:01 2010 -0500 > > i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. > > Thanks to John Faith for suggesting this approach on the ML. The problem is > i2c-tools overwrites the header staged by the kernel. This breaks programs > that depend on the kernel header. I don't think this a good solution. Now all programs break which expect this very i2c-dev.h as being staged by i2c-tools. Interestingly, the desktop distros don't bother about staging it differently, so why can't we do the same? Besides, the i2c-dev.h as staged by i2c-tools is supposed to be a superset. If it isn't we should complain with the i2c-tools developers. What can we do in the meantime? :M: ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. 2010-12-14 12:06 ` [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h Dr. Michael Lauer @ 2010-12-14 13:30 ` Philip Balister 2010-12-14 13:37 ` Martin Jansa 0 siblings, 1 reply; 8+ messages in thread From: Philip Balister @ 2010-12-14 13:30 UTC (permalink / raw) To: openembedded-devel On 12/14/2010 07:06 AM, Dr. Michael Lauer wrote: > Am 10.12.2010 um 15:36 schrieb git version control: > >> Module: openembedded.git >> Branch: org.openembedded.dev >> Commit: 48e6a063370a38a35f31a28efd8f6ce6ebf00840 >> URL: http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=48e6a063370a38a35f31a28efd8f6ce6ebf00840 >> >> Author: Philip Balister<philip@balister.org> >> Date: Fri Dec 10 09:31:01 2010 -0500 >> >> i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. >> >> Thanks to John Faith for suggesting this approach on the ML. The problem is >> i2c-tools overwrites the header staged by the kernel. This breaks programs >> that depend on the kernel header. > > I don't think this a good solution. Now all programs break which expect > this very i2c-dev.h as being staged by i2c-tools. Interestingly, the > desktop distros don't bother about staging it differently, so why > can't we do the same? Besides, the i2c-dev.h as staged by i2c-tools > is supposed to be a superset. If it isn't we should complain with the > i2c-tools developers. > > What can we do in the meantime? Can we get a survey of how other distros handle the situation? My Fedora 14 box does not install the header from i2c-tools and there does not appear to be a dev package. I do not think packages shoudl overwrite headers that come from the kernel. Philip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. 2010-12-14 13:30 ` Philip Balister @ 2010-12-14 13:37 ` Martin Jansa 2010-12-15 8:16 ` Koen Kooi 0 siblings, 1 reply; 8+ messages in thread From: Martin Jansa @ 2010-12-14 13:37 UTC (permalink / raw) To: openembedded-devel On Tue, Dec 14, 2010 at 08:30:46AM -0500, Philip Balister wrote: > On 12/14/2010 07:06 AM, Dr. Michael Lauer wrote: > > Am 10.12.2010 um 15:36 schrieb git version control: > > > >> Module: openembedded.git > >> Branch: org.openembedded.dev > >> Commit: 48e6a063370a38a35f31a28efd8f6ce6ebf00840 > >> URL: http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=48e6a063370a38a35f31a28efd8f6ce6ebf00840 > >> > >> Author: Philip Balister<philip@balister.org> > >> Date: Fri Dec 10 09:31:01 2010 -0500 > >> > >> i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. > >> > >> Thanks to John Faith for suggesting this approach on the ML. The problem is > >> i2c-tools overwrites the header staged by the kernel. This breaks programs > >> that depend on the kernel header. > > > > I don't think this a good solution. Now all programs break which expect > > this very i2c-dev.h as being staged by i2c-tools. Interestingly, the > > desktop distros don't bother about staging it differently, so why > > can't we do the same? Besides, the i2c-dev.h as staged by i2c-tools > > is supposed to be a superset. If it isn't we should complain with the > > i2c-tools developers. > > > > What can we do in the meantime? > > Can we get a survey of how other distros handle the situation? Gentoo i2c-tools-3.0.[012] (all versions) src_install() { emake install prefix="${D}"/usr || die rm -rf "${D}"/usr/include # part of linux-headers ... } so it's not part of i2c-tools package (gentoo doesn't have concept of -dev packages as it's always usefull to have all -dev stuff on source based distribution). -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. 2010-12-14 13:37 ` Martin Jansa @ 2010-12-15 8:16 ` Koen Kooi 2010-12-15 8:29 ` Martin Jansa 0 siblings, 1 reply; 8+ messages in thread From: Koen Kooi @ 2010-12-15 8:16 UTC (permalink / raw) To: openembedded-devel -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 14-12-10 14:37, Martin Jansa wrote: > On Tue, Dec 14, 2010 at 08:30:46AM -0500, Philip Balister wrote: >> On 12/14/2010 07:06 AM, Dr. Michael Lauer wrote: >>> Am 10.12.2010 um 15:36 schrieb git version control: >>> >>>> Module: openembedded.git >>>> Branch: org.openembedded.dev >>>> Commit: 48e6a063370a38a35f31a28efd8f6ce6ebf00840 >>>> URL: http://gitweb.openembedded.net/?p=openembedded.git&a=commit;h=48e6a063370a38a35f31a28efd8f6ce6ebf00840 >>>> >>>> Author: Philip Balister<philip@balister.org> >>>> Date: Fri Dec 10 09:31:01 2010 -0500 >>>> >>>> i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. >>>> >>>> Thanks to John Faith for suggesting this approach on the ML. The problem is >>>> i2c-tools overwrites the header staged by the kernel. This breaks programs >>>> that depend on the kernel header. >>> >>> I don't think this a good solution. Now all programs break which expect >>> this very i2c-dev.h as being staged by i2c-tools. Interestingly, the >>> desktop distros don't bother about staging it differently, so why >>> can't we do the same? Besides, the i2c-dev.h as staged by i2c-tools >>> is supposed to be a superset. If it isn't we should complain with the >>> i2c-tools developers. >>> >>> What can we do in the meantime? >> >> Can we get a survey of how other distros handle the situation? > > Gentoo > i2c-tools-3.0.[012] (all versions) > src_install() { > emake install prefix="${D}"/usr || die > rm -rf "${D}"/usr/include # part of linux-headers > ... > } > > so it's not part of i2c-tools package (gentoo doesn't have concept of > -dev packages as it's always usefull to have all -dev stuff on source > based distribution). What are other distributions based on? Pixie dust? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFNCHlEMkyGM64RGpERAjhiAJ0ZSOL1sTzWT1vz9B5BR4bW4wqwqwCgj2Zh BHqHQqhZva9Zh3MekrMNk7I= =632I -----END PGP SIGNATURE----- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. 2010-12-15 8:16 ` Koen Kooi @ 2010-12-15 8:29 ` Martin Jansa 2010-12-15 12:45 ` Philip Balister 0 siblings, 1 reply; 8+ messages in thread From: Martin Jansa @ 2010-12-15 8:29 UTC (permalink / raw) To: openembedded-devel On Wed, Dec 15, 2010 at 09:16:04AM +0100, Koen Kooi wrote: > What are other distributions based on? Pixie dust? I meant distritubions where end-user normally gets only recipes how to build from source on his machine instead of installing prebuilt binary packages shipped by distribution. -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. 2010-12-15 8:29 ` Martin Jansa @ 2010-12-15 12:45 ` Philip Balister 2010-12-15 13:15 ` Andreas Oberritter 0 siblings, 1 reply; 8+ messages in thread From: Philip Balister @ 2010-12-15 12:45 UTC (permalink / raw) To: openembedded-devel On 12/15/2010 03:29 AM, Martin Jansa wrote: > On Wed, Dec 15, 2010 at 09:16:04AM +0100, Koen Kooi wrote: >> What are other distributions based on? Pixie dust? > > I meant distritubions where end-user normally gets only recipes how to build from source > on his machine instead of installing prebuilt binary packages shipped by distribution. > I am not sure there is a lot od software that uses the problematic header :) Khem suggested we put the file in include/i2c-tools/i2c-dev.h. This means programs that need the i2c-tools version can adjust the header search path with a -I. Philip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. 2010-12-15 12:45 ` Philip Balister @ 2010-12-15 13:15 ` Andreas Oberritter 2010-12-16 6:34 ` Khem Raj 0 siblings, 1 reply; 8+ messages in thread From: Andreas Oberritter @ 2010-12-15 13:15 UTC (permalink / raw) To: openembedded-devel On 12/15/2010 01:45 PM, Philip Balister wrote: > On 12/15/2010 03:29 AM, Martin Jansa wrote: >> On Wed, Dec 15, 2010 at 09:16:04AM +0100, Koen Kooi wrote: >>> What are other distributions based on? Pixie dust? >> >> I meant distritubions where end-user normally gets only recipes how to >> build from source >> on his machine instead of installing prebuilt binary packages shipped >> by distribution. >> > I am not sure there is a lot od software that uses the problematic > header :) > > Khem suggested we put the file in include/i2c-tools/i2c-dev.h. This > means programs that need the i2c-tools version can adjust the header > search path with a -I. I think what Khem suggested was ${include}/i2c-tools/linux/i2c-dev.h, because otherwise programs including <linux/i2c-dev.h> would still pick up the kernel header, even if -I${include}/i2c-tools was prepended to the program's CPPFLAGS. Regards, Andreas ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h. 2010-12-15 13:15 ` Andreas Oberritter @ 2010-12-16 6:34 ` Khem Raj 0 siblings, 0 replies; 8+ messages in thread From: Khem Raj @ 2010-12-16 6:34 UTC (permalink / raw) To: openembedded-devel On (15/12/10 14:15), Andreas Oberritter wrote: > On 12/15/2010 01:45 PM, Philip Balister wrote: > > On 12/15/2010 03:29 AM, Martin Jansa wrote: > >> On Wed, Dec 15, 2010 at 09:16:04AM +0100, Koen Kooi wrote: > >>> What are other distributions based on? Pixie dust? > >> > >> I meant distritubions where end-user normally gets only recipes how to > >> build from source > >> on his machine instead of installing prebuilt binary packages shipped > >> by distribution. > >> > > I am not sure there is a lot od software that uses the problematic > > header :) > > > > Khem suggested we put the file in include/i2c-tools/i2c-dev.h. This > > means programs that need the i2c-tools version can adjust the header > > search path with a -I. > > I think what Khem suggested was ${include}/i2c-tools/linux/i2c-dev.h, > because otherwise programs including <linux/i2c-dev.h> would still pick > up the kernel header, even if -I${include}/i2c-tools was prepended to > the program's CPPFLAGS. Yes. that would be ok too. However I think it will be better to differentiate here in source code. and I would expecte the inclusion of linux/i2c-dev.h to change to i2c-tools/i2c-dev.h that would make it more clear that a given package does not use linux provided header > > Regards, > Andreas > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-12-16 6:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1PR45K-0000jK-SU@melo.openembedded.org>
2010-12-14 12:06 ` [oe-commits] Philip Balister : i2c-tools : Stage i2c-dev.h header as i2c-dev-user.h Dr. Michael Lauer
2010-12-14 13:30 ` Philip Balister
2010-12-14 13:37 ` Martin Jansa
2010-12-15 8:16 ` Koen Kooi
2010-12-15 8:29 ` Martin Jansa
2010-12-15 12:45 ` Philip Balister
2010-12-15 13:15 ` Andreas Oberritter
2010-12-16 6:34 ` Khem Raj
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.