From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Omar Ramirez Luna <omar.ramirez@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] OMAP: RM-680: fix omap2_init_common_hw compile break
Date: Thu, 16 Dec 2010 10:27:55 -0800 [thread overview]
Message-ID: <20101216182755.GI5941@atomide.com> (raw)
In-Reply-To: <20101216180514.GA31322@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [101216 10:05]:
> On Thu, Dec 16, 2010 at 11:27:18AM -0600, Omar Ramirez Luna wrote:
> > diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
> > index 8ba4047..781ed25 100644
> > --- a/arch/arm/mach-omap2/board-am3517crane.c
> > +++ b/arch/arm/mach-omap2/board-am3517crane.c
> > @@ -47,7 +47,8 @@ static void __init am3517_crane_init_irq(void)
> > omap_board_config = am3517_crane_config;
> > omap_board_config_size = ARRAY_SIZE(am3517_crane_config);
> >
> > - omap2_init_common_hw(NULL, NULL);
> > + omap2_init_common_infrastructure();
> > + omap2_init_common_devices(NULL, NULL);
> > omap_init_irq();
>
> Once I have the init_early() sorted, hopefully most of the abuse in
> these callbacks can be moved into the init_early() callback.
Sounds good to me.
Thanks,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: RM-680: fix omap2_init_common_hw compile break
Date: Thu, 16 Dec 2010 10:27:55 -0800 [thread overview]
Message-ID: <20101216182755.GI5941@atomide.com> (raw)
In-Reply-To: <20101216180514.GA31322@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [101216 10:05]:
> On Thu, Dec 16, 2010 at 11:27:18AM -0600, Omar Ramirez Luna wrote:
> > diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c
> > index 8ba4047..781ed25 100644
> > --- a/arch/arm/mach-omap2/board-am3517crane.c
> > +++ b/arch/arm/mach-omap2/board-am3517crane.c
> > @@ -47,7 +47,8 @@ static void __init am3517_crane_init_irq(void)
> > omap_board_config = am3517_crane_config;
> > omap_board_config_size = ARRAY_SIZE(am3517_crane_config);
> >
> > - omap2_init_common_hw(NULL, NULL);
> > + omap2_init_common_infrastructure();
> > + omap2_init_common_devices(NULL, NULL);
> > omap_init_irq();
>
> Once I have the init_early() sorted, hopefully most of the abuse in
> these callbacks can be moved into the init_early() callback.
Sounds good to me.
Thanks,
Tony
next prev parent reply other threads:[~2010-12-16 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 17:27 [PATCH] OMAP: RM-680: fix omap2_init_common_hw compile break Omar Ramirez Luna
2010-12-16 17:27 ` Omar Ramirez Luna
2010-12-16 18:05 ` Russell King - ARM Linux
2010-12-16 18:05 ` Russell King - ARM Linux
2010-12-16 18:27 ` Tony Lindgren [this message]
2010-12-16 18:27 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216182755.GI5941@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.