All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next] ipv6: remove duplicate neigh_ifdown
Date: Thu, 16 Dec 2010 19:42:54 -0800	[thread overview]
Message-ID: <20101216194254.0f7c7e7b@nehalam> (raw)
In-Reply-To: <20101216175152.6767d0a7@nehalam>

When device is being set to down, neigh_ifdown was being called
twice. Once from addrconf notifier and once from ndisc notifier.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/net/ipv6/addrconf.c	2010-12-16 17:50:26.658169250 -0800
+++ b/net/ipv6/addrconf.c	2010-12-16 17:52:15.227220647 -0800
@@ -2672,7 +2672,6 @@ static int addrconf_ifdown(struct net_de
 	/* Flush routes if device is being removed or it is not loopback */
 	if (how || !(dev->flags & IFF_LOOPBACK))
 		rt6_ifdown(net, dev);
-	neigh_ifdown(&nd_tbl, dev);
 
 	idev = __in6_dev_get(dev);
 	if (idev == NULL)

       reply	other threads:[~2010-12-17  3:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20101216175152.6767d0a7@nehalam>
2010-12-17  3:42 ` Stephen Hemminger [this message]
2010-12-17 17:49   ` [PATCH net-next] ipv6: remove duplicate neigh_ifdown David Miller
2010-12-17 18:01     ` Stephen Hemminger
2010-12-17 18:14       ` David Miller
2010-12-19  6:02   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101216194254.0f7c7e7b@nehalam \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.