From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: remove duplicate neigh_ifdown
Date: Fri, 17 Dec 2010 10:01:01 -0800 [thread overview]
Message-ID: <20101217100101.5e6e6708@nehalam> (raw)
In-Reply-To: <20101217.094916.193712831.davem@davemloft.net>
On Fri, 17 Dec 2010 09:49:16 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Thu, 16 Dec 2010 19:42:54 -0800
>
> > When device is being set to down, neigh_ifdown was being called
> > twice. Once from addrconf notifier and once from ndisc notifier.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> I'll give you a cookie if you can show me how this patch applies to
> net-next-2.6 cleanly. :-)
>
> It only matches the code in net-2.6 which has changed non-trivially in
> net-next-2.6
>
> If you worked against net-2.6 and thought "I can't think of anything
> that could have changed in net-next-2.6 in this area", that's not
> an appropriate way to operate and submit patches.
>
> Please don't be so careless, thanks.
Ok. It followed my last patch that did the rt6_ifdown only
if not loopback. Since you accepted that, I sent the next one.
--
next prev parent reply other threads:[~2010-12-17 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101216175152.6767d0a7@nehalam>
2010-12-17 3:42 ` [PATCH net-next] ipv6: remove duplicate neigh_ifdown Stephen Hemminger
2010-12-17 17:49 ` David Miller
2010-12-17 18:01 ` Stephen Hemminger [this message]
2010-12-17 18:14 ` David Miller
2010-12-19 6:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217100101.5e6e6708@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.