All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Lunz <lunz@acm.org>
To: Anatolij Gustschin <agust@denx.de>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
	atom ota <atomota@sleepyhammer.com>,
	user-mode-linux-devel@lists.sourceforge.net,
	richard -rw- weinberger <richard.weinberger@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, Jeff Dike <jdike@addtoit.com>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org, Rob Landley <rob@landley.net>,
	David Woodhouse <dwmw2@infradead.org>
Subject: mtd: fix CONFIG_MTD_COMPLEX_MAPPINGS=n compile
Date: Thu, 16 Dec 2010 20:27:59 -0800	[thread overview]
Message-ID: <20101217042759.GA3148@falooley.org> (raw)
In-Reply-To: <20101216230110.65156c55@wker>

On Thu, Dec 16, 2010 at 11:01:10PM +0100, Anatolij Gustschin wrote:
> This change breaks compiling when CONFIG_MTD_COMPLEX_MAPPINGS is not
> defined in the kernel configuration. Please fix!

Sorry, sloppy of me. This reverts all changes to mtd.h while keeping the
ability to compile mtd on ARCH=um, with the exception mtdchar.

Jason

--

Revert hiding of inline_map_* functions in linux/mtd.h, and mark
MTD_CHAR as incompatible with uml until a better solution can be found
there.

Signed-off-by: Jason Lunz <lunz@acm.org>

---
 drivers/mtd/Kconfig     |    1 +
 include/linux/mtd/map.h |   18 +++++++++---------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 7537654..51471a5 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -174,6 +174,7 @@ comment "User Modules And Translation Layers"
 
 config MTD_CHAR
 	tristate "Direct char device access to MTD devices"
+	depends on HAS_IOMEM
 	help
 	  This provides a character device for each MTD device present in
 	  the system, allowing the user to read and write directly to the
diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h
index 3d9f7e0..a9e6ba4 100644
--- a/include/linux/mtd/map.h
+++ b/include/linux/mtd/map.h
@@ -388,15 +388,6 @@ static inline map_word map_word_ff(struct map_info *map)
 	return r;
 }
 
-#ifdef CONFIG_MTD_COMPLEX_MAPPINGS
-#define map_read(map, ofs) (map)->read(map, ofs)
-#define map_copy_from(map, to, from, len) (map)->copy_from(map, to, from, len)
-#define map_write(map, datum, ofs) (map)->write(map, datum, ofs)
-#define map_copy_to(map, to, from, len) (map)->copy_to(map, to, from, len)
-
-extern void simple_map_init(struct map_info *);
-#define map_is_linear(map) (map->phys != NO_XIP)
-
 static inline map_word inline_map_read(struct map_info *map, unsigned long ofs)
 {
 	map_word r;
@@ -449,6 +440,15 @@ static inline void inline_map_copy_to(struct map_info *map, unsigned long to, co
 	memcpy_toio(map->virt + to, from, len);
 }
 
+#ifdef CONFIG_MTD_COMPLEX_MAPPINGS
+#define map_read(map, ofs) (map)->read(map, ofs)
+#define map_copy_from(map, to, from, len) (map)->copy_from(map, to, from, len)
+#define map_write(map, datum, ofs) (map)->write(map, datum, ofs)
+#define map_copy_to(map, to, from, len) (map)->copy_to(map, to, from, len)
+
+extern void simple_map_init(struct map_info *);
+#define map_is_linear(map) (map->phys != NO_XIP)
+
 #else
 #define map_read(map, ofs) inline_map_read(map, ofs)
 #define map_copy_from(map, to, from, len) inline_map_copy_from(map, to, from, len)
-- 
1.7.2.3


  reply	other threads:[~2010-12-17  4:27 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <22c797d00709272118i33d32b9dy93d5f5ec8f8edd30@mail.gmail.com>
2007-10-24  1:17 ` [PATCH] allow use of mtd and jffs2 on uml Jason Lunz
2007-10-24  6:51   ` David Woodhouse
2007-10-24 15:54     ` Jason Lunz
2007-10-24 15:54       ` Jason Lunz
2007-10-24 16:24       ` atom ota
2007-10-24 16:24         ` atom ota
2007-12-27 18:15     ` Jason Lunz
2007-12-27 18:15       ` Jason Lunz
2007-12-27 18:15       ` [uml-devel] " Jason Lunz
2007-12-28 17:48       ` Sam Ravnborg
2007-12-28 17:48         ` Sam Ravnborg
2007-12-28 17:48         ` [uml-devel] " Sam Ravnborg
2010-12-07  7:29         ` [PATCH] mtd: allow mtd and jffs2 when ARCH=um Jason Lunz
2010-12-07  7:29           ` Jason Lunz
2010-12-07  9:39           ` richard -rw- weinberger
2010-12-07  9:39             ` richard -rw- weinberger
2010-12-07  9:39             ` richard -rw- weinberger
2010-12-07 18:20             ` Jason Lunz
2010-12-07 18:20               ` Jason Lunz
2010-12-07 18:20               ` Jason Lunz
2010-12-14 16:24               ` Artem Bityutskiy
2010-12-14 16:24                 ` Artem Bityutskiy
2010-12-14 19:51                 ` Jason Lunz
2010-12-14 19:51                   ` Jason Lunz
2010-12-14 20:01                   ` Artem Bityutskiy
2010-12-14 20:01                     ` Artem Bityutskiy
2010-12-14 21:12                     ` Geert Uytterhoeven
2010-12-14 21:12                       ` Geert Uytterhoeven
2010-12-14 21:23                     ` Jason Lunz
2010-12-14 21:23                       ` Jason Lunz
2010-12-15  0:40                       ` Rob Landley
2010-12-15  0:40                         ` Rob Landley
2010-12-15  0:49                     ` Rob Landley
2010-12-15  0:49                       ` Rob Landley
2010-12-15  1:19                       ` Jason Lunz
2010-12-15  1:19                         ` Jason Lunz
2010-12-15  6:31                         ` Rob Landley
2010-12-15  6:31                           ` Rob Landley
2010-12-16 15:18                           ` Artem Bityutskiy
2010-12-16 15:18                             ` Artem Bityutskiy
2010-12-18  4:08                             ` Rob Landley
2010-12-18  4:08                               ` Rob Landley
2010-12-19 17:08                               ` Artem Bityutskiy
2010-12-19 17:08                                 ` Artem Bityutskiy
2010-12-15  8:18                         ` Geert Uytterhoeven
2010-12-15  8:18                           ` Geert Uytterhoeven
2010-12-16 15:25                   ` Artem Bityutskiy
2010-12-16 15:25                     ` Artem Bityutskiy
2010-12-16 22:01                   ` Anatolij Gustschin
2010-12-16 22:01                     ` Anatolij Gustschin
2010-12-17  4:27                     ` Jason Lunz [this message]
2010-12-19 16:47                       ` mtd: fix CONFIG_MTD_COMPLEX_MAPPINGS=n compile Artem Bityutskiy
2010-12-19 16:47                         ` Artem Bityutskiy
2010-12-19 19:07                         ` Jason Lunz
2010-12-19 19:07                           ` Jason Lunz
2010-12-20 11:23                           ` Artem Bityutskiy
2010-12-20 11:23                             ` Artem Bityutskiy
2010-12-20 14:04                             ` [PATCH] mtd: allow mtd and jffs2 when ARCH=um Jason Lunz
2010-12-20 14:04                               ` Jason Lunz
2010-12-22 14:40                               ` Artem Bityutskiy
2010-12-22 14:40                                 ` Artem Bityutskiy
2011-01-06 15:45                   ` David Woodhouse
2011-01-06 15:45                     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101217042759.GA3148@falooley.org \
    --to=lunz@acm.org \
    --cc=agust@denx.de \
    --cc=atomota@sleepyhammer.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.weinberger@gmail.com \
    --cc=rob@landley.net \
    --cc=sam@ravnborg.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.