From: Tony Lindgren <tony@atomide.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm: mach-omap2: Kconfig: devkit8000 should select needed options
Date: Fri, 17 Dec 2010 16:21:31 -0800 [thread overview]
Message-ID: <20101218002131.GZ5941@atomide.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1012171424030.13087@esdhcp041196.research.nokia.com>
* Aaro Koskinen <aaro.koskinen@nokia.com> [101217 04:41]:
> Hi,
>
> On Wed, 15 Dec 2010, Tony Lindgren wrote:
> >* Aaro Koskinen <aaro.koskinen@nokia.com> [101215 04:48]:
> >>It's not possible to compile a kernel for this board without I2C,
> >>MFD_SUPPORT and TWL4030_CORE, so those should be selected. This will
> >>prevent build errors when trying out different configurations.
> >
> >This one I'm not so convinced about. We should be able to compile
> >support for each board and enable and disable these kind of options
> >just fine if CONFIG_ARCH_OMAP2PLUS_TYPICAL is disabled.
>
> So in this case we should move the stuff with special dependencies from
> the board file into e.g. board-devkit8000-peripherals, which would be
> a kernel module?
Or how about just have them in ifdef CONFIG_I2C_OMAP and TWL4030_CORE
in the board-devkit8000.c file?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: mach-omap2: Kconfig: devkit8000 should select needed options
Date: Fri, 17 Dec 2010 16:21:31 -0800 [thread overview]
Message-ID: <20101218002131.GZ5941@atomide.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1012171424030.13087@esdhcp041196.research.nokia.com>
* Aaro Koskinen <aaro.koskinen@nokia.com> [101217 04:41]:
> Hi,
>
> On Wed, 15 Dec 2010, Tony Lindgren wrote:
> >* Aaro Koskinen <aaro.koskinen@nokia.com> [101215 04:48]:
> >>It's not possible to compile a kernel for this board without I2C,
> >>MFD_SUPPORT and TWL4030_CORE, so those should be selected. This will
> >>prevent build errors when trying out different configurations.
> >
> >This one I'm not so convinced about. We should be able to compile
> >support for each board and enable and disable these kind of options
> >just fine if CONFIG_ARCH_OMAP2PLUS_TYPICAL is disabled.
>
> So in this case we should move the stuff with special dependencies from
> the board file into e.g. board-devkit8000-peripherals, which would be
> a kernel module?
Or how about just have them in ifdef CONFIG_I2C_OMAP and TWL4030_CORE
in the board-devkit8000.c file?
Regards,
Tony
next prev parent reply other threads:[~2010-12-18 0:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 12:49 [PATCH 1/2] arm: mach-omap2: Kconfig: fix incorrect option Aaro Koskinen
2010-12-15 12:49 ` Aaro Koskinen
2010-12-15 12:49 ` [PATCH 2/2] arm: mach-omap2: Kconfig: devkit8000 should select needed options Aaro Koskinen
2010-12-15 12:49 ` Aaro Koskinen
2010-12-15 17:37 ` Tony Lindgren
2010-12-15 17:37 ` Tony Lindgren
2010-12-17 12:41 ` Aaro Koskinen
2010-12-17 12:41 ` Aaro Koskinen
2010-12-18 0:21 ` Tony Lindgren [this message]
2010-12-18 0:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218002131.GZ5941@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.