From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] omap: rx51: Remove __initdata from rx51_tpa6130a2_data
Date: Fri, 17 Dec 2010 16:24:39 -0800 [thread overview]
Message-ID: <20101218002439.GA5941@atomide.com> (raw)
In-Reply-To: <1292613505-10113-1-git-send-email-jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [101217 11:16]:
> If the TPA6130 is compiled as module the id and power_gpio values are
> arbitrary at module probing time since the rx51_tpa6130a2_data was marked as
> __initdata.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---
> For 2.6.38 as the TPA6130 is not used in 2.6.37.
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 126b724..cde6847 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -719,7 +719,7 @@ static struct twl4030_platform_data rx51_twldata __initdata = {
> .vio = &rx51_vio,
> };
>
> -static struct tpa6130a2_platform_data rx51_tpa6130a2_data __initdata = {
> +static struct tpa6130a2_platform_data rx51_tpa6130a2_data = {
> .id = TPA6130A2,
> .power_gpio = 98,
> };
How about __initdata_or_module instead of __initdata?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] omap: rx51: Remove __initdata from rx51_tpa6130a2_data
Date: Fri, 17 Dec 2010 16:24:39 -0800 [thread overview]
Message-ID: <20101218002439.GA5941@atomide.com> (raw)
In-Reply-To: <1292613505-10113-1-git-send-email-jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [101217 11:16]:
> If the TPA6130 is compiled as module the id and power_gpio values are
> arbitrary at module probing time since the rx51_tpa6130a2_data was marked as
> __initdata.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---
> For 2.6.38 as the TPA6130 is not used in 2.6.37.
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 126b724..cde6847 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -719,7 +719,7 @@ static struct twl4030_platform_data rx51_twldata __initdata = {
> .vio = &rx51_vio,
> };
>
> -static struct tpa6130a2_platform_data rx51_tpa6130a2_data __initdata = {
> +static struct tpa6130a2_platform_data rx51_tpa6130a2_data = {
> .id = TPA6130A2,
> .power_gpio = 98,
> };
How about __initdata_or_module instead of __initdata?
Regards,
Tony
next prev parent reply other threads:[~2010-12-18 0:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 19:18 [PATCH 1/3] omap: rx51: Remove __initdata from rx51_tpa6130a2_data Jarkko Nikula
2010-12-17 19:18 ` Jarkko Nikula
2010-12-17 19:18 ` [PATCH 2/3] omap: rx51: Remove extra tlv320aic3x.h inclusion Jarkko Nikula
2010-12-17 19:18 ` Jarkko Nikula
2010-12-17 19:18 ` [PATCH 3/3] omap: rx51: Add supplies and data for codec b part of TLV320AIC34 Jarkko Nikula
2010-12-17 19:18 ` Jarkko Nikula
2010-12-18 0:24 ` Tony Lindgren [this message]
2010-12-18 0:24 ` [PATCH 1/3] omap: rx51: Remove __initdata from rx51_tpa6130a2_data Tony Lindgren
2010-12-18 18:17 ` [PATCHv2] omap: rx51: Switch rx51_tpa6130a2_data __initdata to __initdata_or_module Jarkko Nikula
2010-12-18 18:17 ` Jarkko Nikula
2010-12-21 1:14 ` Tony Lindgren
2010-12-21 1:14 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101218002439.GA5941@atomide.com \
--to=tony@atomide.com \
--cc=jhnikula@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.